Return cache if asleep instead of error - #157
Open
JKSProds wants to merge 19 commits into
Open
Conversation
…ehicle again. Testing
This program is a fork of the main TeslaBleHttpProxy with some changes so it works correctly with EVCC.
Added CS charge state default if not in range to Disconnected
Changed FastChargerType, ConnChargeCable, and FastChargerBrand from pointers to strings.
Replace '<nil>' with 'null' in response JSON.
|
@JKSProds thanks for the fix. Have tested it and confirms that it works correctly with evcc now. you might want to delete |
|
Is there anything preventing this from being merged? In its current form this proxy is sadly unusable for EVCC. |
|
There is some cleanup required before merging. @JKSProds could you please cleanup your code, so this PR can be merged? See the comment from @chrisdebruin Also remove your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.