Add drive_state endpoint to vehicle_data - #160
Open
Optic00 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
drive_stateto the supportedendpointsvalues ofGET /api/1/vehicles/{vin}/vehicle_data, primarily to expose the odometer so that downstream consumers like evcc can read it over BLE. Companion PR for the evcc vehicle template: evcc-io/evcc#31743.Changes
drive_stateadded toExceptedEndpointsand mapped tovehicle.StateCategoryDrive(the existingdrivealias keeps working).DriveStateFromBleconverter, modeled onChargeStateFromBle. Mapped fields:timestamp,shift_state(oneof converted to "P"/"R"/"N"/"D"; SNA/Invalid/unset become an empty string),speed(prefersspeed_float, falls back to the older integerspeedfield via the oneof presence accessors),power,odometer.odometeris converted from the protobuf's hundredths-of-a-mile field to miles. Note: the Fleet API historically returns the odometer invehicle_state, but the BLE protocol delivers it inDriveState, so it is exposed here (documented in a code comment).LocationState, notDriveState.drive_statedocumented as requestable via theendpointsparameter; the default response (no parameter) is unchanged (charge_state+climate_state).shift_stateoneof arms, odometer conversion including the unset case, and the speed fallback.Example response (
?endpoints=drive_state){"response": {"result": true, "response": {"drive_state": {"timestamp": 1752345600, "shift_state": "", "speed": 0, "power": 0, "odometer": 17720.11}}}}Testing
go build ./...andgo test ./internal/api/models/...pass.TestAllExceptedCommandsImplementedininternal/tesla/commandspanics on a nil*vehicle.Vehiclealready on currentmain; that failure is pre-existing and unrelated to this change.