Fix PHP 8.4 and 8.5 deprecations#229
Open
austinderrick wants to merge 1 commit into
Open
Conversation
- Config\Repository: use '' rather than a null $namespace as the afterLoad array offset (PHP 8.5 'Using null as an array offset is deprecated'). - Halcyon\Processors\Processor: same for the fileName offset (array_get may return null). - Console\Traits\ProcessesQuery: explicit ?int $limit (PHP 8.4 implicit-nullable param). - Html\FormBuilder::selectMonth: replace deprecated strftime() with date() (default 'F'). - tests: update ScheduleListCommandTest invokable-class schedule:list expectation to match current Laravel 12.x rendering (pre-existing failure on wip/1.3, unrelated to the above).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the PHP 8.4 and 8.5 deprecations.
Fixes
Using null as an array offset is deprecated, use an empty string instead):src/Config/Repository.php—afterLoad[$namespace](read/isset/write) now uses$namespace ?? ''(a null/global namespace is a valid case). (This is the one reported.)src/Halcyon/Processors/Processor.php—$items[$fileName]/[$fileName => …]now uses$fileName ?? ''(array_get($result, 'fileName')may return null).src/Console/Traits/ProcessesQuery.php—int $limit = null→?int $limit = null.strftime():src/Html/FormBuilder.php::selectMonth()— replacedstrftime()withdate(); the$formatdefault changes from'%B'to'F'(date() syntax). Default output (full month names) is unchanged; callers passing customstrftime-style formats must switch todate()syntax.tests/Scheduling/ScheduleListCommandTest— updated the invokable-classschedule:listexpectation (modern Laravel renders the bare class name without theClosure at:prefix). This was a pre-existing failure onwip/1.3unrelated to the deprecations.Testing
vendor/bin/phpuniton PHP 8.5.5: 711 tests, 0 failures, 0 Storm-source PHP deprecations.vendor/bin/phpuniton PHP 8.4.14: 711 tests, 0 failures, 0 Storm-source PHP deprecations.phpcs: clean on the changed files.Out of scope
vendor/assetic/frameworktriggers a$http_response_headerdeprecation on 8.5 — that's a third-party dependency, not Storm.wip/1.3(a larastan-version drift, in the relation generics / baseline) that are unrelated to this PR; they are addressed for the Laravel 13 line in Support Laravel 13 #228.