models: normalize embedding class to class:embed (drop legacy alias)#13
Open
wolfy-j wants to merge 1 commit into
Open
models: normalize embedding class to class:embed (drop legacy alias)#13wolfy-j wants to merge 1 commit into
wolfy-j wants to merge 1 commit into
Conversation
Standardize on the single canonical class:embed. The text-embedding-3-small model carried both class:embed and a legacy class:embedding alias; nothing references class:embedding anymore (keeper resolves class:embed, and its embedding fallback to class:embedding was removed). Keeps the embedding class taxonomy consistent across keeper, apps, and this template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
text-embedding-3-smallwas declared on bothclass:embedand a legacyclass:embeddingalias. This dropsclass:embedding, standardizing on the single canonicalclass:embed.Why
The dual
embed/embeddingnaming was an inconsistency. Nothing referencesclass:embeddinganymore:class:embedas its primary embedding class; its fallback toclass:embeddinghas been removed (keeper 0.5.24).class:embed.This keeps the embedding-class taxonomy consistent across keeper, consuming apps, and this template.
Change
class: - embed - - embeddingNo behavior change —
class:embedalready resolved to this model.