chore: migrate persistence to async SQLDelight on JS [WPB-23964]#3982
Open
Garzas wants to merge 8 commits into
Open
chore: migrate persistence to async SQLDelight on JS [WPB-23964]#3982Garzas wants to merge 8 commits into
Garzas wants to merge 8 commits into
Conversation
Contributor
Contributor
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3982 +/- ##
=============================================
+ Coverage 61.55% 61.61% +0.05%
+ Complexity 4022 3986 -36
=============================================
Files 2068 2069 +1
Lines 67436 67698 +262
Branches 6651 6674 +23
=============================================
+ Hits 41513 41709 +196
- Misses 23277 23317 +40
- Partials 2646 2672 +26
... and 41 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
c130456 to
f26f7a8
Compare
MohamadJaara
approved these changes
May 13, 2026
saleniuk
approved these changes
May 13, 2026
3dddedd to
a9bfb4f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



https://wearezeta.atlassian.net/browse/WPB-23964
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
Issues
web-worker-driver, but the persistence layer still assumed synchronous generated SQLDelight APIs.IllegalStateException: The driver used with SQLDelight is asynchronous, so SQLDelight should be configured for asynchronous usage.generateAsync = truefor Kalium databases caused broad compile fallout because DAO, bootstrap, paging, migration, and helper code still depended on synchronous query access patterns.Causes (Optional)
0/1for boolean-like columns, while generated Kotlin models expect booleans for selected fields.Solutions
UserDatabaseandGlobalDatabaseindata:persistence.suspendwhere required through DAOs, repositories, helpers, and affected tests.SELECT EXISTS.DROP VIEW IF EXISTSwhere needed.nuke, DB path, empty file creation) so the remaining non-native parity gaps are explicit.