Skip to content

feat: iOS AVS calling support [WPB-24959] #4130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Garzas wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

feat: iOS AVS calling support [WPB-24959] #4130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b551408
iOS AVS: wire call manager and flow manager for video paths
Garzas Apr 30, 2026
328159c
fix: scope AVS KMP dependency to iOS source sets
Garzas May 12, 2026
0d8e798
Merge branch 'develop' into feat/ios-avs-calling-support
Garzas May 12, 2026
bc9cd41
detekt fix
Garzas May 12, 2026
dd064c0
import fix
Garzas May 12, 2026
15bc414
Merge branch 'develop' into feat/ios-avs-calling-support
Garzas May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions domain/calling/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,13 @@ kotlin {
implementation(libs.jna)
}
}
matching { sourceSet ->
sourceSet.name.startsWith("ios") && sourceSet.name.endsWith("Main")
}.all {
dependencies {
api(libs.avsKmp)
}
}
Comment on lines +68 to +74
Copy link
Copy Markdown
Contributor

@saleniuk saleniuk May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use the same approach as for other platforms?
Something like:

val iosMain by getting {
    dependencies {
        api(libs.avsKmp)
    }
}


val commonTest by getting {
dependencies { }
Expand Down
1 change: 1 addition & 0 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ difference-jvm = { module = "dev.andrewbailey.difference:difference-jvm", versio

# avs
avs = { module = "com.wire:avs", version.ref = "avs" }
avsKmp = { module = "com.wire:avs-kmp", version.ref = "avs" }
Copy link
Copy Markdown
Contributor

@saleniuk saleniuk May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't be better to separate the version numbers for regular and kmp?

jna = { module = "net.java.dev.jna:jna", version.ref = "jna" }

# logging
Expand Down
Loading
Loading