fix: stabilize Keychain service name for iOS to prevent orphaned entries [WPB-25123]#4138
Open
MohamadJaara wants to merge 2 commits into
Open
fix: stabilize Keychain service name for iOS to prevent orphaned entries [WPB-25123]#4138MohamadJaara wants to merge 2 commits into
MohamadJaara wants to merge 2 commits into
Conversation
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4138 +/- ##
==========================================
Coverage 61.55% 61.56%
- Complexity 4021 4022 +1
==========================================
Files 2067 2068 +1
Lines 67423 67436 +13
Branches 6650 6651 +1
==========================================
+ Hits 41500 41514 +14
- Misses 23276 23277 +1
+ Partials 2647 2645 -2 see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Contributor
Bencher Report
johnxnguyen
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-25123
What's new in this PR?
Issues
On iOS, every new app deployment assigns a fresh Application UUID, changing
NSHomeDirectory()and thus the absolute container path. iOS migrates filesystem data to the new path, but the Keychain is independent of the filesystem — entries written under the old path are orphaned. Result: stored auth tokens become unreadable →SESSION_EXPIRED→ forced logout.Solutions
ask consumer apps to deal with it and they can provide a stable identifier