Skip to content

chore: more generic event for user admin promotion (WPB-25283)#4147

Open
sbakhtiarov wants to merge 1 commit into
developfrom
chore/admin-promo-event-refactor
Open

chore: more generic event for user admin promotion (WPB-25283)#4147
sbakhtiarov wants to merge 1 commit into
developfrom
chore/admin-promo-event-refactor

Conversation

@sbakhtiarov
Copy link
Copy Markdown
Contributor

@sbakhtiarov sbakhtiarov commented May 18, 2026

https://wearezeta.atlassian.net/browse/WPB-25283

https://wearezeta.atlassian.net/browse/WPB-25283

What's new in this PR?

More generic event handling for user role change.

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

Test Results

0 tests   - 4 919   0 ✅  - 4 804   0s ⏱️ - 3m 0s
0 suites  -   808   0 💤  -   115 
0 files    -   808   0 ❌ ±    0 

Results for commit a35abcc. ± Comparison against base commit 9a0b40b.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.56%. Comparing base (9a0b40b) to head (a35abcc).

Files with missing lines Patch % Lines
...om/wire/kalium/logic/data/message/MessageMapper.kt 0.00% 3 Missing ⚠️
...kalium/logic/data/message/PersistMessageUseCase.kt 0.00% 2 Missing ⚠️
...m/wire/kalium/logic/data/message/MessageContent.kt 50.00% 0 Missing and 1 partial ⚠️
...re/kalium/persistence/dao/message/MessageMapper.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4147   +/-   ##
==========================================
  Coverage      61.56%   61.56%           
  Complexity      4022     4022           
==========================================
  Files           2069     2069           
  Lines          67472    67473    +1     
  Branches        6658     6658           
==========================================
+ Hits           41540    41541    +1     
  Misses         23285    23285           
  Partials        2647     2647           
Files with missing lines Coverage Δ
...re/kalium/persistence/dao/message/MessageEntity.kt 81.58% <100.00%> (ø)
.../receiver/conversation/MemberChangeEventHandler.kt 100.00% <100.00%> (+1.96%) ⬆️
...m/wire/kalium/logic/data/message/MessageContent.kt 46.83% <50.00%> (ø)
...re/kalium/persistence/dao/message/MessageMapper.kt 61.41% <0.00%> (ø)
...kalium/logic/data/message/PersistMessageUseCase.kt 19.48% <0.00%> (ø)
...om/wire/kalium/logic/data/message/MessageMapper.kt 16.85% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a0b40b...a35abcc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branchchore/admin-promo-event-refactor
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
903.80 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
334,517.63 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.inboxPagingDeepPageBenchmark📈 view plot
⚠️ NO THRESHOLD
130,591.00 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.inboxPagingFirstPageBenchmark📈 view plot
⚠️ NO THRESHOLD
124,958.01 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.localMarkAsReadBenchmark📈 view plot
⚠️ NO THRESHOLD
3,311.14 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.messagePagingDeepPageBenchmark📈 view plot
⚠️ NO THRESHOLD
27,451.18 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.messagePagingFirstPageBenchmark📈 view plot
⚠️ NO THRESHOLD
11,304.02 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,234,144.38 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
20,385.85 µs
🐰 View full continuous benchmarking report in Bencher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants