Skip to content

refactor: replace wrapKaliumResponse with wrapRequest [WPB-8645]#4157

Open
MohamadJaara wants to merge 4 commits into
developfrom
mo/refactor/remove-deprecate-wrapKaliumResponse
Open

refactor: replace wrapKaliumResponse with wrapRequest [WPB-8645]#4157
MohamadJaara wants to merge 4 commits into
developfrom
mo/refactor/remove-deprecate-wrapKaliumResponse

Conversation

@MohamadJaara
Copy link
Copy Markdown
Member

@MohamadJaara MohamadJaara commented May 21, 2026

https://wearezeta.atlassian.net/browse/WPB-8645

Replace deprecated wrapKaliumResponse with wrapRequest

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

Test Results

0 tests   - 4 945   0 ✅  - 4 830   0s ⏱️ - 2m 48s
0 suites  -   811   0 💤  -   115 
0 files    -   811   0 ❌ ±    0 

Results for commit 4fc4b44. ± Comparison against base commit d62cb85.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 21, 2026

Codecov Report

❌ Patch coverage is 65.51724% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.59%. Comparing base (d62cb85) to head (4fc4b44).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../network/api/v0/authenticated/ConversationApiV0.kt 55.00% 7 Missing and 2 partials ⚠️
...um/network/api/v0/unauthenticated/RegisterApiV0.kt 0.00% 4 Missing ⚠️
...re/kalium/network/api/base/unbound/acme/ACMEApi.kt 50.00% 3 Missing ⚠️
...kalium/network/api/v0/authenticated/ClientApiV0.kt 66.66% 3 Missing ⚠️
...e/kalium/network/api/v0/authenticated/SelfApiV0.kt 40.00% 3 Missing ⚠️
.../kalium/network/api/v0/authenticated/TeamsApiV0.kt 62.50% 3 Missing ⚠️
...kalium/network/api/v0/authenticated/LogoutApiV0.kt 33.33% 2 Missing ⚠️
...um/network/api/v0/unauthenticated/SSOLoginApiV0.kt 66.66% 2 Missing ⚠️
.../network/api/v4/authenticated/ConversationApiV4.kt 50.00% 2 Missing ⚠️
.../network/api/v8/authenticated/ConversationApiV8.kt 50.00% 2 Missing ⚠️
... and 17 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #4157      +/-   ##
=============================================
- Coverage      61.60%   61.59%   -0.01%     
- Complexity      4028     4029       +1     
=============================================
  Files           2074     2074              
  Lines          67765    67762       -3     
  Branches        6690     6695       +5     
=============================================
- Hits           41748    41741       -7     
  Misses         23355    23355              
- Partials        2662     2666       +4     
Files with missing lines Coverage Δ
...nticated/systemsettings/UnauthorizedSettingsApi.kt 100.00% <100.00%> (ø)
.../kalium/network/api/v0/authenticated/AssetApiV0.kt 61.03% <100.00%> (ø)
...e/kalium/network/api/v0/authenticated/CallApiV0.kt 73.33% <100.00%> (ø)
.../network/api/v0/authenticated/NotificationApiV0.kt 46.03% <100.00%> (-1.59%) ⬇️
...um/network/api/v0/authenticated/PropertiesApiV0.kt 92.85% <100.00%> (ø)
...m/network/api/v0/authenticated/UserDetailsApiV0.kt 83.33% <100.00%> (ø)
...alium/network/api/v0/unauthenticated/LoginApiV0.kt 78.94% <100.00%> (ø)
...rk/api/v0/unauthenticated/VerificationCodeApiV0.kt 82.60% <100.00%> (ø)
...etwork/api/v10/authenticated/ConversationApiV10.kt 88.88% <100.00%> (ø)
...v10/unauthenticated/GetDomainRegistrationApiV10.kt 88.88% <100.00%> (ø)
... and 42 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d62cb85...4fc4b44. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MohamadJaara MohamadJaara changed the title refactor: replace wrapKaliumResponse with wrapRequest refactor: replace wrapKaliumResponse with wrapRequest [WPB-8645] May 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

🐰 Bencher Report

Branchmo/refactor/remove-deprecate-wrapKaliumResponse
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
673.38 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
604,674.24 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.inboxPagingDeepPageBenchmark📈 view plot
⚠️ NO THRESHOLD
103,124.37 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.inboxPagingFirstPageBenchmark📈 view plot
⚠️ NO THRESHOLD
98,925.39 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.localMarkAsReadBenchmark📈 view plot
⚠️ NO THRESHOLD
2,844.34 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.messagePagingDeepPageBenchmark📈 view plot
⚠️ NO THRESHOLD
22,988.34 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.messagePagingFirstPageBenchmark📈 view plot
⚠️ NO THRESHOLD
10,453.61 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,262,356.20 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
22,975.98 µs
🐰 View full continuous benchmarking report in Bencher

@MohamadJaara MohamadJaara requested a review from ohassine May 21, 2026 13:45
@MohamadJaara MohamadJaara enabled auto-merge May 21, 2026 13:45
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants