Skip to content

refactor: replace deprecated ErrorResponse and handleUnsuccessfulResponse with GenericAPIErrorResponse and interceptUnsuccessfulResponse [WPB-8645]#4159

Open
MohamadJaara wants to merge 1 commit into
developfrom
mo/refactor/replace-deprecated-ErrorResponse-and-handleUnsuccessfulResponse
Open

refactor: replace deprecated ErrorResponse and handleUnsuccessfulResponse with GenericAPIErrorResponse and interceptUnsuccessfulResponse [WPB-8645]#4159
MohamadJaara wants to merge 1 commit into
developfrom
mo/refactor/replace-deprecated-ErrorResponse-and-handleUnsuccessfulResponse

Conversation

@MohamadJaara
Copy link
Copy Markdown
Member

@MohamadJaara MohamadJaara commented May 21, 2026

https://wearezeta.atlassian.net/browse/WPB-8645

replace deprecated ErrorResponse and handleUnsuccessfulResponse with GenericAPIErrorResponse and interceptUnsuccessfulResponse

…onse with GenericAPIErrorResponse and interceptUnsuccessfulResponse
@sonarqubecloud
Copy link
Copy Markdown

@MohamadJaara MohamadJaara changed the title refactor: replace deprecated ErrorResponse and handleUnsuccessfulResponse with GenericAPIErrorResponse and interceptUnsuccessfulResponse refactor: replace deprecated ErrorResponse and handleUnsuccessfulResponse with GenericAPIErrorResponse and interceptUnsuccessfulResponse [WPB-8645] May 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

Test Results

0 tests   - 4 941   0 ✅  - 4 826   0s ⏱️ - 2m 40s
0 suites  -   810   0 💤  -   115 
0 files    -   810   0 ❌ ±    0 

Results for commit b2ffa7e. ± Comparison against base commit e205957.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.58%. Comparing base (e205957) to head (b2ffa7e).

Files with missing lines Patch % Lines
...re/kalium/network/api/base/unbound/acme/ACMEApi.kt 0.00% 2 Missing ⚠️
...m/wire/kalium/network/utils/HttpResponseHandler.kt 86.66% 2 Missing ⚠️
...tlin/com/wire/kalium/network/utils/NetworkUtils.kt 0.00% 2 Missing ⚠️
...e/kalium/network/api/v5/authenticated/E2EIApiV5.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #4159      +/-   ##
=============================================
- Coverage      61.60%   61.58%   -0.02%     
  Complexity      4028     4028              
=============================================
  Files           2073     2073              
  Lines          67742    67757      +15     
  Branches        6685     6686       +1     
=============================================
- Hits           41735    41731       -4     
- Misses         23346    23367      +21     
+ Partials        2661     2659       -2     
Files with missing lines Coverage Δ
.../kalium/network/api/v0/authenticated/AssetApiV0.kt 61.03% <100.00%> (ø)
...twork/api/v0/authenticated/NomadDeviceSyncApiV0.kt 62.06% <100.00%> (ø)
.../network/api/v0/authenticated/NotificationApiV0.kt 47.61% <100.00%> (ø)
.../wire/kalium/network/exceptions/KaliumException.kt 86.53% <100.00%> (ø)
...tlin/com/wire/kalium/network/utils/CustomErrors.kt 95.23% <100.00%> (ø)
...e/kalium/network/api/v5/authenticated/E2EIApiV5.kt 68.75% <0.00%> (ø)
...re/kalium/network/api/base/unbound/acme/ACMEApi.kt 29.68% <0.00%> (ø)
...m/wire/kalium/network/utils/HttpResponseHandler.kt 86.31% <86.66%> (+0.06%) ⬆️
...tlin/com/wire/kalium/network/utils/NetworkUtils.kt 25.33% <0.00%> (-21.34%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e205957...b2ffa7e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branchmo/refactor/replace-deprecated-ErrorResponse-and-handleUnsuccessfulResponse
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
878.69 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
331,781.09 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.inboxPagingDeepPageBenchmark📈 view plot
⚠️ NO THRESHOLD
128,541.42 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.inboxPagingFirstPageBenchmark📈 view plot
⚠️ NO THRESHOLD
122,238.57 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.localMarkAsReadBenchmark📈 view plot
⚠️ NO THRESHOLD
3,306.85 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.messagePagingDeepPageBenchmark📈 view plot
⚠️ NO THRESHOLD
27,354.43 µs
com.wire.kalium.benchmarks.persistence.MessageReadBenchmark.messagePagingFirstPageBenchmark📈 view plot
⚠️ NO THRESHOLD
11,502.32 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,220,267.37 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
20,371.04 µs
🐰 View full continuous benchmarking report in Bencher

} else {
// FIXME: It doesn't make any sense to do the regular handling of unsuccessful response here,
// as ACME is NOT the Wire API, and doesn't follow its error response format.
handleUnsuccessfulResponse(httpResponse)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove handleUnsuccessfulResponse() since it's no longer used ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants