Skip to content

chore: more generic event for user admin promotion (WPB-25283)#4830

Merged
sbakhtiarov merged 1 commit into
developfrom
chore/admin-promo-event-refactor
May 22, 2026
Merged

chore: more generic event for user admin promotion (WPB-25283)#4830
sbakhtiarov merged 1 commit into
developfrom
chore/admin-promo-event-refactor

Conversation

@sbakhtiarov
Copy link
Copy Markdown
Contributor

@sbakhtiarov sbakhtiarov commented May 18, 2026

https://wearezeta.atlassian.net/browse/WPB-25283

https://wearezeta.atlassian.net/browse/WPB-25283

What's new in this PR?

More generic event handling for user role change. Keep more generic event for future, show system message only when self user is promoted to admin role.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.77%. Comparing base (76d6bf2) to head (f5809f8).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4830      +/-   ##
===========================================
+ Coverage    51.74%   51.77%   +0.02%     
===========================================
  Files          612      612              
  Lines        21262    21265       +3     
  Branches      3411     3412       +1     
===========================================
+ Hits         11003    11009       +6     
+ Misses        9240     9237       -3     
  Partials      1019     1019              
Files with missing lines Coverage Δ
.../wire/android/mapper/SystemMessageContentMapper.kt 47.30% <100.00%> (+2.18%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d6bf2...f5809f8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbakhtiarov sbakhtiarov force-pushed the chore/admin-promo-event-refactor branch from 9512f7b to f5809f8 Compare May 22, 2026 11:55
@sbakhtiarov sbakhtiarov enabled auto-merge May 22, 2026 11:56
@sonarqubecloud
Copy link
Copy Markdown

@sbakhtiarov sbakhtiarov added this pull request to the merge queue May 22, 2026
Merged via the queue into develop with commit f97939a May 22, 2026
20 checks passed
@sbakhtiarov sbakhtiarov deleted the chore/admin-promo-event-refactor branch May 22, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants