Skip to content

refactor: Reduce message list mapping and ViewModel scope overhead #4857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MohamadJaara wants to merge 2 commits into
base: mo/refactor/markdown-formating-while-mapping-conversaions
Choose a base branch
from

refactor: Optimize scoped message view model keys

3561303
Select commit
Loading
Failed to load commit list.
Open

refactor: Reduce message list mapping and ViewModel scope overhead #4857

refactor: Optimize scoped message view model keys
3561303
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 21, 2026 in 1s

51.23% (+0.03%) compared to 47174d4

View this Pull Request on Codecov

51.23% (+0.03%) compared to 47174d4

Details

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.23%. Comparing base (47174d4) to head (3561303).

Files with missing lines Patch % Lines
...wire/android/mapper/RegularMessageContentMapper.kt 50.00% 1 Missing ⚠️
...e/android/ui/home/conversations/model/UIMessage.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                                      Coverage Diff                                      @@
##           mo/refactor/markdown-formating-while-mapping-conversaions    #4857      +/-   ##
=============================================================================================
+ Coverage                                                      51.19%   51.23%   +0.03%     
=============================================================================================
  Files                                                            612      612              
  Lines                                                          21172    21188      +16     
  Branches                                                        3421     3421              
=============================================================================================
+ Hits                                                           10839    10855      +16     
+ Misses                                                          9318     9316       -2     
- Partials                                                        1015     1017       +2
Files with missing lines Coverage Δ
...ndroid/ui/home/conversations/model/MessageTypes.kt 14.28% <ø> (ø)
...wire/android/mapper/RegularMessageContentMapper.kt 17.12% <50.00%> (-1.40%) ⬇️
...e/android/ui/home/conversations/model/UIMessage.kt 40.68% <83.33%> (+0.74%) ⬆️

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47174d4...3561303. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov