Skip to content

test: create channel convo (WPB-25729)#4858

Merged
emmaoke-w merged 8 commits into
developfrom
test/WPB-25729-create-channel-convo
May 21, 2026
Merged

test: create channel convo (WPB-25729)#4858
emmaoke-w merged 8 commits into
developfrom
test/WPB-25729-create-channel-convo

Conversation

@emmaoke-w
Copy link
Copy Markdown
Contributor

@emmaoke-w emmaoke-w commented May 21, 2026

https://wearezeta.atlassian.net/browse/WPB-25729


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Adds channel test coverage for the creator-driven delete flow in ChannelTest
  • Covers the flow of returning to the conversation list, long-pressing the channel, opening delete actions, confirming removal, and validating the removed state.
  • Verifies the delete confirmation modal and removed toast behavior in the channel flow.

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@emmaoke-w emmaoke-w marked this pull request as ready for review May 21, 2026 13:10
Comment thread tests/testsSupport/src/main/backendUtils/team/TeamHelper.kt Outdated
Copy link
Copy Markdown
Collaborator

@CinnamonNinja CinnamonNinja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have a small suggestion regarding the supported protocols, but it's not needed for this test that you wrote.

@emmaoke-w emmaoke-w removed the request for review from yamilmedina May 21, 2026 14:56
@sonarqubecloud
Copy link
Copy Markdown

@emmaoke-w emmaoke-w enabled auto-merge May 21, 2026 15:15
@emmaoke-w emmaoke-w added this pull request to the merge queue May 21, 2026
Merged via the queue into develop with commit b9f67ff May 21, 2026
19 checks passed
@emmaoke-w emmaoke-w deleted the test/WPB-25729-create-channel-convo branch May 21, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants