Max comments#40
Open
maxha651 wants to merge 43 commits into
Open
Conversation
streaming info when displayed. Needs to be fixed
graph displaying useless data
memory leak as well.. Needs work
Needs to show absolute value
zoom & drag funcition. Lots of trash code that needs to be cleaned
scroll with keyboard.
either iat dev or bitrate on graph.
works with setRange
accessible for graph!
it only updates it for one stream at a time.
axis titles, ts-files, changeStream doesnt work well for IAT dev.
actually working pretty well.
maxha651
commented
Aug 2, 2019
maxha651
left a comment
maxha651
left a comment
Collaborator
Author
There was a problem hiding this comment.
A bunch of commented code and whitespace should also be removed.
|
|
||
|
|
||
|
|
||
| if (lastDuration > 1000000000){ |
| if (duration - lastDuration >= emitFrequency) { | ||
| bitrate = (bytes - lastSecondBytes)*8*1000/(duration - lastDuration); | ||
| lastSecondBytes = bytes; | ||
| // lastDuration = duration; |
Collaborator
Author
There was a problem hiding this comment.
Don't use lastDuration in two places like this. Not sure this is actually run.
emitFrequency should mean that this is run every emit, in that case just move it to the other "emit" code below.
|
|
||
| emit status(AnalyzerStatus(Status::STATUS_PERIODIC, bytes, duration, bitrate, duration, pidMap, tsErrors, proto, tsPerIp)); | ||
| emit workerStatus(WorkerStatus(WorkerStatus::STATUS_PERIODIC, streams)); | ||
| if(bitrate / 1000000 < 100){ |
Collaborator
Author
There was a problem hiding this comment.
Shouldn't need this check
| QString s3 = "IAT deviation"; | ||
|
|
||
| QString string = ( s1+ s2 + s3 ); | ||
| stream << string << endl; |
Collaborator
Author
There was a problem hiding this comment.
Minor point: Use "\n" or "\r\n" as newline (consistently) instead of endl.
So we don't depend on whatever the implementation thinks endl is. Also I think it's an implicit flush.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.