fix: preserve CSS propagation for partial pages imported as components#16415
Open
0xbejaxer wants to merge 6 commits intowithastro:mainfrom
Open
fix: preserve CSS propagation for partial pages imported as components#164150xbejaxer wants to merge 6 commits intowithastro:mainfrom
0xbejaxer wants to merge 6 commits intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: f22ad01 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Treat top-level pages as CSS boundaries only when they are referenced exclusively by the virtual page module, so partial pages imported as components continue propagating transitive styles in production builds. Made-with: Cursor
9a87942 to
01986de
Compare
Correct the regression fixture path so the partial page can resolve ResultsTable during build on CI. Made-with: Cursor
Assert that scoped ResultsTable selectors are present in extracted styles instead of matching a specific color token that can be minified differently across environments. Made-with: Cursor
Author
|
Quick update after addressing CI feedback:
All checks are now passing on this branch. Happy to adjust test coverage/assertions further if maintainers prefer a different shape. |
Open
1 task
|
Thanks @0xbejaxer ! |
Trigger a fresh workflow run for PR withastro#16415 after unrelated flaky E2E failures in actions-blog/cloudflare/hmr tests. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
export const partial = true) that are imported by other pages to keep propagating transitive component CSS in production buildsindex.htmloutputValidation
pnpm -C packages/astro exec astro-scripts test "test/partials-css-boundary.test.ts"Fixes #16296.