Skip to content

fix(assets): pass through images Sharp cannot decode instead of crashing #16451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maximslo wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(assets): pass through images Sharp cannot decode instead of crashing #16451

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
616de7f
fix(assets): pass through images Sharp cannot decode instead of crashing
maximslo Apr 23, 2026
c6b9f40
test(assets): add test for animated AVIF pass-through
maximslo Apr 24, 2026
9a0bbbf
test(assets): add test for animated AVIF pass-through
maximslo Apr 24, 2026
7bcdbd3
fix(test): remove incorrect avif extension assertion
maximslo Apr 24, 2026
a4d6ed0
chore: add changeset for animated AVIF fix
maximslo Apr 24, 2026
0d3f832
Merge branch 'main' into fix/animated-avif-passthrough
maximslo Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/astro/src/assets/services/sharp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,14 @@ const sharpService: LocalImageService<SharpImageServiceConfig> = {
result.rotate();

// get some information about the input
const { format } = await result.metadata();
let format: string | undefined;
try {
({ format } = await result.metadata());
} catch {
// Sharp cannot decode this image (e.g. animated AVIF sequences).
// Pass it through unmodified rather than crashing the build.
return { data: inputBuffer, format: transform.format };
}

if (transform.width && transform.height) {
const fit: keyof FitEnum | undefined = transform.fit
Expand Down
10 changes: 10 additions & 0 deletions packages/astro/test/core-image.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,6 +1078,16 @@ describe('astro:image', () => {
);
});

it('animated avif does not crash the build', async () => {
const html = await fixture.readFile('/animated-avif/index.html');
const $ = cheerio.load(html);
const src = $('#animated-avif img').attr('src')!;
assert.ok(src, 'expected img src to be set');
const data = await fixture.readBuffer(src);
assert.equal(data instanceof Buffer, true);
assert.ok(data.byteLength > 0);
});

it('markdown images are written', async () => {
const html = await fixture.readFile('/post/index.html');
const $ = cheerio.load(html);
Expand Down
Binary file added packages/astro/test/fixtures/core-image-ssg/src/assets/animated.avif
View file
Open in desktop
Binary file not shown.
11 changes: 11 additions & 0 deletions packages/astro/test/fixtures/core-image-ssg/src/pages/animated-avif.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
import { Image } from 'astro:assets';
import animatedAvif from '../assets/animated.avif';
---
<html>
<body>
<div id="animated-avif">
<Image src={animatedAvif} alt="animated avif" />
</div>
</body>
</html>
Loading