test: cover actions with all prerendered pages#16465
Open
statxc wants to merge 1 commit intowithastro:mainfrom
Open
test: cover actions with all prerendered pages#16465statxc wants to merge 1 commit intowithastro:mainfrom
statxc wants to merge 1 commit intowithastro:mainfrom
Conversation
|
Author
|
Hi @ematipico , @alexanderniebuhr how are you? Please review this. I also have some personal questions regarding contribution. Can we contact on telegram or other community? |
Member
|
https://astro.build/chat/ is the only official community we use |
Author
|
Hi @alexanderniebuhr could you please review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test for astro:actions to ensure projects with an adapter and all pages prerendered can still use action RPC routes in dev and build.
Fixes:#16256
Changes
astro:actionswhen an adapter is configured and all project pages are prerendered.output: "server", an adapter, one prerendered page, and an action RPC route.Testing
pnpm -C packages/astro buildpnpm -C packages/astro exec astro-scripts test "test/actions.test.ts" --strip-types --match "Astro Actions with adapter and all project pages prerendered" --timeout 180000 --force-exitpnpm -C packages/astro exec astro-scripts test "test/actions.test.ts" --strip-types --timeout 300000 --force-exitDocs
No docs changes needed. This only adds regression test coverage for existing
astro:actionsbehavior.