[PoC] Add processing of MuSig2 fields#127
Draft
bigspider wants to merge 1 commit into
Draft
Conversation
bigspider
changed the title
Contributor
|
Happy to test this, but I would prefer it to be based on a |
Contributor
|
I would also suggest splitting the ledger_bitcoin_client update into its own PR. |
Contributor
Author
|
Working here for rust-bitcoin: rust-bitcoin/rust-bitcoin#6087 |
Contributor
Contributor
Author
|
rust-bitcoin's psbt module does not yet implement suport for PSBT_IN_MUSIG2_PUB_NONCE and PSBT_IN_MUSIG2_PARTIAL_SIG. This commit adds them to the PSBT using the raw 'unknown' map. It should be reverted once proper support is added upstream.
bigspider
force-pushed
the
update-ledgerlib
branch
from
55fff32 to
67b2822
Compare
bigspider
changed the title
Contributor
Author
|
I dropped the first commit (already merged with #129). |
Contributor
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a (Claude-assisted) PR to add support for signing transaction
Current caveats:
unknownmap. It should still be compliant with BIP174 and BIP-373.