GPU: WebGPU back-end#1356
Open
slomp wants to merge 18 commits into
Open
Conversation
f8a7334 to
fc33759
Compare
starmole
reviewed
May 18, 2026
Contributor
starmole
left a comment
There was a problem hiding this comment.
just two small comments around event loop
| static_cast<uint64_t>(m_queryLimit) * sizeof(uint64_t), cbInfo); | ||
|
|
||
| // Optimistic immediate poll: deliver any already-completed callbacks. | ||
| wgpuInstanceProcessEvents(m_instance); |
Contributor
There was a problem hiding this comment.
i would recommend not calling process events here.
a client integrating it will call process events in it's own frame loop.
and it will be very confusing if their callbacks start to come from within Collect.
| m_writeIdx = newWriteIdx; | ||
|
|
||
| WGPUBufferMapCallbackInfo cbInfo = {}; | ||
| cbInfo.mode = WGPUCallbackMode_AllowSpontaneous; |
Contributor
There was a problem hiding this comment.
i would recommend AllowProcessEvents only. AllowSpontaneous is quite dangerous. It can fire on arbitrary different threads.
430d601 to
44112fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype status:
webgpu.h)SetupDeviceis made re-entrant (to be addressed by future PRs)The most convoluted portions of the back-end are the "readback buffer reel" and the "clock calibration".
wgpuBufferMapAsync), and the other buffer is being processed byCollect(). They rotate in round-robin as needed (Collect orchestrates the rotation by updating an atomic variable).