Skip to content

[TO TEST] - Highlight text - Fix issue when moving the caret and autocorrected words#18148

Closed
geriux wants to merge 1 commit into
trunkfrom
gutenberg/upgrade-aztec-highlighted-text-issue
Closed

[TO TEST] - Highlight text - Fix issue when moving the caret and autocorrected words#18148
geriux wants to merge 1 commit into
trunkfrom
gutenberg/upgrade-aztec-highlighted-text-issue

Conversation

@geriux
Copy link
Copy Markdown
Contributor

@geriux geriux commented Mar 16, 2022

Fixes WordPress/gutenberg#38246

This PR fixes two current issues with the highlight text feature:

  • Now moving the caret after highlighting some words won't keep the previously selected color when typing new characters.
  • Autocorrected wors will keep the highlighted color when the new entry is replaced.

To test check the Gutenberg PR description.

Regression Notes

  1. Potential unintended areas of impact
    This only affects the block editor.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing of the highlight text feature and integration tests.

  3. What automated tests I added (or what prevented me from doing so)
    One within Aztec.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Mar 16, 2022

You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr18148-17516ff. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Mar 16, 2022

You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr18148-17516ff. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@peril-wordpress-mobile
Copy link
Copy Markdown

Fails
🚫 Podfile: reference to a commit hash

Generated by 🚫 dangerJS

@twstokes
Copy link
Copy Markdown
Contributor

👋 I'm going to close this PR due to lack of activity, but please reopen if this was an error. Thank you.

@twstokes twstokes closed this Aug 25, 2023
@geriux geriux deleted the gutenberg/upgrade-aztec-highlighted-text-issue branch June 18, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Highlight text: Format button doesn't match current color when moving the caret

3 participants