Include strings referenced in GB-mobile files in localization strings files#4410
Merged
Conversation
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Contributor
|
Hey, @fluiddot . We will cut the |
jhnstn
approved these changes
Jan 4, 2022
Member
jhnstn
left a comment
There was a problem hiding this comment.
Looks good. npm run genstrings executed as expected.
(I did get the "Text color" string as you noted in the test steps.)
# Conflicts: # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the file
strings-overrides.js(reference) we have some strings which are not currently translated due to not being included in the localization strings files. This PR adds newmake-potcommands to extract strings also from source files of GB-mobile repository.Strings referenced in GB-mobile:
gutenberg-mobile/src/strings-overrides.js
Lines 19 to 21 in 313e993
gutenberg-mobile/src/strings-overrides.js
Lines 27 to 29 in 313e993
gutenberg-mobile/src/strings-overrides.js
Line 55 in 313e993
These strings are mainly used in the unsupported block editor modal:
To test:
npm run genstrings.bundle/ios/GutenbergNativeTranslations.swiftandbundle/android/strings.xml) remain unmodified.NOTE: Most likely the string
Text colorwould be added if Specify domain when extracting strings from Jetpack and Layout Grid #4409 is not already merged, please omit this string as it will be included on that PR.PR submission checklist: