Skip to content

Include strings referenced in GB-mobile files in localization strings files#4410

Merged
fluiddot merged 4 commits into
developfrom
add/gb-mobile-strings
Jan 5, 2022
Merged

Include strings referenced in GB-mobile files in localization strings files#4410
fluiddot merged 4 commits into
developfrom
add/gb-mobile-strings

Conversation

@fluiddot
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot commented Dec 29, 2021

In the file strings-overrides.js (reference) we have some strings which are not currently translated due to not being included in the localization strings files. This PR adds new make-pot commands to extract strings also from source files of GB-mobile repository.

Strings referenced in GB-mobile:

These strings are mainly used in the unsupported block editor modal:

To test:

  1. Run command npm run genstrings.
  2. Observe that the localization strings files (bundle/ios/GutenbergNativeTranslations.swift and bundle/android/strings.xml) remain unmodified.
    NOTE: Most likely the string Text color would be added if Specify domain when extracting strings from Jetpack and Layout Grid #4409 is not already merged, please omit this string as it will be included on that PR.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot requested a review from jhnstn December 29, 2021 14:44
@fluiddot fluiddot self-assigned this Dec 29, 2021
@fluiddot fluiddot added this to the 1.69.0 (19.0) milestone Dec 29, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile Bot commented Dec 29, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ttahmouch
Copy link
Copy Markdown
Contributor

Hey, @fluiddot . We will cut the 1.69.0 release on Thursday, January 6, 2022. We plan to circle back and bump this PR to the next milestone then, but please let me know if you'd rather us work to include this PR in 1.69.0.

Copy link
Copy Markdown
Member

@jhnstn jhnstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. npm run genstrings executed as expected.
(I did get the "Text color" string as you noted in the test steps.)

@fluiddot fluiddot enabled auto-merge January 5, 2022 09:44
@fluiddot fluiddot merged commit c93aa0f into develop Jan 5, 2022
@fluiddot fluiddot deleted the add/gb-mobile-strings branch January 5, 2022 10:01
@mkevins mkevins mentioned this pull request Jan 7, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants