Skip to content

fix: pollyfill crypto and add typedVersions #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Takaros999 merged 3 commits into from
Apr 8, 2026
Merged

fix: pollyfill crypto and add typedVersions #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0148d93
pollyfill crypto and add typedVersions
Takaros999 Apr 7, 2026
4c190e4
smoke test
Takaros999 Apr 7, 2026
18a04b3
fmt
Takaros999 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions js/packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,19 @@
"require": "./dist/session.cjs"
}
},
"typesVersions": {
"*": {
"signing": [
"./dist/signing.d.ts"
],
"hashing": [
"./dist/hashing.d.ts"
],
"session": [
"./dist/session.d.ts"
]
}
},
"files": [
"dist"
],
Expand Down
13 changes: 13 additions & 0 deletions js/packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,19 @@
"require": "./dist/session.cjs"
}
},
"typesVersions": {
"*": {
"signing": [
"./dist/signing.d.ts"
],
"hashing": [
"./dist/hashing.d.ts"
],
"session": [
"./dist/session.d.ts"
]
}
},
"files": [
"dist",
"README.md"
Expand Down
9 changes: 9 additions & 0 deletions js/packages/server/src/__tests__/cjs-compat.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,13 @@ describe("CJS bundle compatibility", () => {
expect(mod).toBeDefined();
expect(typeof mod.signRequest).toBe("function");
});

it("should call signRequest without crypto errors", async () => {
const mod = await import(cjsPath);
const result = mod.signRequest({ signingKeyHex: "aa".repeat(32) });
expect(result.sig).toMatch(/^0x[0-9a-f]{130}$/);
expect(result.nonce).toMatch(/^0x[0-9a-f]{64}$/);
expect(result.createdAt).toBeTypeOf("number");
expect(result.expiresAt).toBeTypeOf("number");
});
});
6 changes: 6 additions & 0 deletions js/packages/server/src/lib/signing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ import { sha256 } from "@noble/hashes/sha2";
import { sign, etc } from "@noble/secp256k1";
import { isServerEnvironment } from "./platform";

// Node <19 CJS doesn't expose globalThis.crypto; polyfill it so @noble libs and our code can use it
if (typeof globalThis.crypto === "undefined") {
// eslint-disable-next-line @typescript-eslint/no-require-imports
globalThis.crypto = require("node:crypto").webcrypto;
}

// Configure @noble/secp256k1 with synchronous HMAC-SHA256 from @noble/hashes
etc.hmacSha256Sync = (key: Uint8Array, ...msgs: Uint8Array[]) =>
hmac(sha256, key, etc.concatBytes(...msgs));
Expand Down
Loading