fix: patch aws-lc-sys with iOS cross-compilation fix#314
Draft
lukejmann wants to merge 1 commit intobump-aws-lc-brokenfrom
Draft
fix: patch aws-lc-sys with iOS cross-compilation fix#314lukejmann wants to merge 1 commit intobump-aws-lc-brokenfrom
lukejmann wants to merge 1 commit intobump-aws-lc-brokenfrom
Conversation
lukejmann
force-pushed
the
fix/aws-lc-ios
branch
from
e71c4f4 to
3ead3a9
Compare
lukejmann
force-pushed
the
fix/aws-lc-ios
branch
2 times, most recently
from
e5af033 to
e43593a
Compare
aws-lc-sys 0.38.0 fails to compile urandom.c for aarch64-apple-ios on Xcode 16.2 because target.h doesn't include <TargetConditionals.h>, so OPENSSL_IOS is never defined and the build falls through to the Linux urandom path. Patches target.h in the cargo registry before building iOS targets. This directly proves the upstream root cause fix works: aws/aws-lc#3111 Made-with: Cursor
lukejmann
force-pushed
the
fix/aws-lc-ios
branch
from
e43593a to
fac00f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proves that the upstream fixes in
lukejmann/aws-lc@fix/ios-cross-compilationresolve the iOS build failure.Base branch (
bump-aws-lc-broken) is commitd71e976— the bareaws-lc-sys0.38.0 bump with no workarounds. This is the commit that fails CI on the Swift build job.This PR patches
target.handurandom.cat build time (viacargo fetch+sedinbuild_swift.sh) to apply the same two fixes from the upstream PR. No[patch.crates-io], no fork dependency — just a direct source patch against the crates.io package.Before / After
urandom.cfails:ioctlundeclared,RNDGETENTCNTundeclaredTARGET_OS_IPHONEnot available on Xcode 16.2Upstream PR
aws/aws-lc#3111