Skip to content

chore: bump world-id-core 0.6 → 0.7 #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dzejkop merged 1 commit into from
Mar 25, 2026
Merged

chore: bump world-id-core 0.6 → 0.7 #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 52 additions & 22 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ alloy-core = { version = "1", default-features = false, features = [
] }
alloy-primitives = { version = "1", default-features = false }
uniffi = { version = "0.31", features = ["tokio"] }
world-id-core = { version = "0.6", default-features = false }
world-id-core = { version = "0.7", default-features = false }

# internal
walletkit-core = { version = "0.11.1", path = "walletkit-core", default-features = false }
Expand Down
10 changes: 3 additions & 7 deletions walletkit-core/src/credential.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,10 @@ impl Credential {
self.0.expires_at
}

/// Returns the credential's `associated_data_hash` field element.
///
/// This is a Poseidon2 commitment to the associated data (e.g. a PCP archive)
/// set by the issuer at issuance time. Returns `FieldElement::ZERO` if no
/// associated data was committed to.
/// Returns the associated-data commitment field element for this credential.
#[must_use]
pub fn associated_data_hash(&self) -> FieldElement {
self.0.associated_data_hash.into()
pub fn associated_data_commitment(&self) -> FieldElement {
self.0.associated_data_commitment.into()
}
}

Expand Down
3 changes: 1 addition & 2 deletions walletkit-core/tests/proof_generation_integration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,9 @@ use alloy::signers::{local::PrivateKeySigner, SignerSync};
use alloy::sol;
use alloy_primitives::U160;
use eyre::{Context as _, Result};
use taceo_oprf::types::OprfKeyId;
use walletkit_core::storage::cache_embedded_groth16_material;
use walletkit_core::{defaults::DefaultConfig, Authenticator, Environment};
use world_id_core::primitives::{rp::RpId, FieldElement, Nullifier};
use world_id_core::primitives::{rp::RpId, FieldElement, Nullifier, OprfKeyId};
Copy link
Copy Markdown

@cursor cursor bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused taceo-oprf dev-dependency after import migration

Low Severity

Moving the OprfKeyId import from taceo_oprf::types to world_id_core::primitives was the only usage of the taceo-oprf dev-dependency in walletkit-core/Cargo.toml (line 80). That dev-dependency (with its TODO comment about removal) is now completely unused — the remaining taceo_oprf references in logger.rs are just string literals for log filtering, not actual crate imports. The dev-dep can be removed.

Fix in Cursor Fix in Web

Copy link
Copy Markdown
Contributor

@paolodamico paolodamico Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes I added this import. /otto worth removing the direct taceo dep now

use world_id_core::{
requests::{ProofRequest, RequestItem, RequestVersion},
Authenticator as CoreAuthenticator, EdDSAPrivateKey,
Expand Down
Loading