Skip to content

github: add version-alignment job #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eldenpark merged 6 commits into from
Apr 9, 2026
+34 −6
Merged

github: add version-alignment job #348

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cb3b057
github: add version-alignment job
eldenpark Apr 6, 2026
dff1d58
Bump "rust-toolchain-channel" to 1.94.1
eldenpark Apr 6, 2026
4e59bce
Update uniffi to 0.31.0
eldenpark Apr 6, 2026
6e59af0
Merge branch 'main' into elden/version-alignment-1
eldenpark Apr 8, 2026
aed35f9
Pin version-alignment action to immutable commit SHA
eldenpark Apr 8, 2026
8ce4b39
Set it reference the action at the main branch
eldenpark Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,21 @@ env:
CARGO_TERM_COLOR: always

jobs:
version-alignment:
name: Version Alignment
runs-on: ubuntu-latest
permissions:
contents: read

steps:
- name: Checkout code
uses: actions/checkout@v6

Comment on lines +24 to +26
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout@v6 is referenced by a mutable tag. To make CI runs reproducible and reduce action supply-chain risk, pin this to a specific commit SHA (or at least a specific major+minor tag if your org policy allows).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown

@aurel-fr aurel-fr Apr 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this and we do pin to sha in other repos. I think it's more acceptable to reference a branch for repositories that belong to us like bedrock but for those actions that we don't own, it's safer to pin.

Copy link
Copy Markdown
Contributor Author

@eldenpark eldenpark Apr 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aurel-fr ^ Specified a commit SHA of the upstream repo (version alignment script)

- uses: worldcoin/bedrock/.github/actions/version-alignment@main
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow references the Bedrock composite action by branch (worldcoin/bedrock/.github/actions/version-alignment@main). For supply-chain safety and reproducibility, pin this to an immutable ref (a release tag or full commit SHA) instead of main, otherwise CI behavior can change (or be compromised) without any change in this repo.

Suggested change
- uses: worldcoin/bedrock/.github/actions/version-alignment@main
- uses: worldcoin/bedrock/.github/actions/version-alignment@<FULL_40_CHAR_COMMIT_SHA>

Copilot uses AI. Check for mistakes.
with:
uniffi_version: ${{ vars.UNIFFI_VERSION }}
rust_toolchain_channel: ${{ vars.RUST_TOOLCHAIN_CHANNEL }}

lint:
name: Format, Clippy & Build
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 8 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
[workspace]
members = ["uniffi-bindgen", "walletkit-core", "walletkit", "walletkit-db", "walletkit-cli"]
members = [
"uniffi-bindgen",
"walletkit-core",
"walletkit",
"walletkit-db",
"walletkit-cli",
]
resolver = "2"

[workspace.package]
Expand All @@ -21,7 +27,7 @@ alloy-core = { version = "1", default-features = false, features = [
"sol-types",
] }
alloy-primitives = { version = "1", default-features = false }
uniffi = { version = "0.31", features = ["tokio"] }
uniffi = { version = "0.31.0", features = ["tokio"] }
world-id-core = { version = "0.8", default-features = false }

# internal
Expand Down
2 changes: 1 addition & 1 deletion rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[toolchain]
channel = "1.92.0"
channel = "1.94.1"
profile = "default"
components = ["rustfmt", "clippy", "rust-analyzer"]
targets = [
Expand Down
Loading