Conversation
gryaele
commented
Apr 8, 2026
gryaele
commented
Apr 8, 2026
| @@ -78,7 +88,18 @@ impl RecoveryBindingManager { | |||
Contributor
Author
There was a problem hiding this comment.
Leaf index can be take from the authenticator, but I also noticed that it's sometimes passed as a param. What is the recommendation here?
Contributor
There was a problem hiding this comment.
imo we should take it from the authenticator. Can we also take sub?
Contributor
Author
There was a problem hiding this comment.
we'd need blinding factor I think, I couldn't find a method to get the sub in the Authenticator
Dzejkop
reviewed
Apr 8, 2026
Dzejkop
reviewed
Apr 8, 2026
Co-authored-by: Jakub Trąd <jakubtrad@gmail.com>
Dzejkop
reviewed
Apr 8, 2026
Co-authored-by: Jakub Trąd <jakubtrad@gmail.com>
Co-authored-by: Jakub Trąd <jakubtrad@gmail.com>
Dzejkop
reviewed
Apr 8, 2026
Co-authored-by: Jakub Trąd <jakubtrad@gmail.com>
Dzejkop
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request extends the
ManageRecoveryBindingRequeststruct and updates related logic and tests to support recovery agent updates in the recovery bindings flow. The main changes add new fields for signature, nonce, and the new recovery agent address, and ensure these are handled throughout the codebase and tests.Recovery agent update support
signature,nonce, andnew_recovery_agentfields to theManageRecoveryBindingRequeststruct inpop_backend_client.rsto support recovery agent update operations. ([walletkit-core/src/issuers/pop_backend_client.rsR16-R22](https://github.com/worldcoin/walletkit/pull/349/files#diff-3824125edaf8fa9a81da332d83ba961405575a0321b8f820a336f9ec4c62eb00R16-R22))bind_recovery_agentandunbind_recovery_agentmethods inrecovery_bindings_manager.rsto generate and include the new fields when constructingManageRecoveryBindingRequest, using the authenticator to sign the update and pass the new recovery agent address. ([[1]](https://github.com/worldcoin/walletkit/pull/349/files#diff-592fea17b31859cf09d8c8fe2190249b35dd84316d9d99180a0d6ff2b3fbd23fR81-R93),[[2]](https://github.com/worldcoin/walletkit/pull/349/files#diff-592fea17b31859cf09d8c8fe2190249b35dd84316d9d99180a0d6ff2b3fbd23fL112-R134))Test updates
pop_backend_client.rsandrecovery_bindings_manager.rsto include and validate the new fields (signature,nonce,new_recovery_agent) in requests and mock expectations. ([[1]](https://github.com/worldcoin/walletkit/pull/349/files#diff-3824125edaf8fa9a81da332d83ba961405575a0321b8f820a336f9ec4c62eb00R226-R242),[[2]](https://github.com/worldcoin/walletkit/pull/349/files#diff-3824125edaf8fa9a81da332d83ba961405575a0321b8f820a336f9ec4c62eb00R271-R287),[[3]](https://github.com/worldcoin/walletkit/pull/349/files#diff-3824125edaf8fa9a81da332d83ba961405575a0321b8f820a336f9ec4c62eb00R324-R337),[[4]](https://github.com/worldcoin/walletkit/pull/349/files#diff-3824125edaf8fa9a81da332d83ba961405575a0321b8f820a336f9ec4c62eb00R366-R383),[[5]](https://github.com/worldcoin/walletkit/pull/349/files#diff-592fea17b31859cf09d8c8fe2190249b35dd84316d9d99180a0d6ff2b3fbd23fR249-R250),[[6]](https://github.com/worldcoin/walletkit/pull/349/files#diff-592fea17b31859cf09d8c8fe2190249b35dd84316d9d99180a0d6ff2b3fbd23fL235-R263),[[7]](https://github.com/worldcoin/walletkit/pull/349/files#diff-592fea17b31859cf09d8c8fe2190249b35dd84316d9d99180a0d6ff2b3fbd23fL257-R288),[[8]](https://github.com/worldcoin/walletkit/pull/349/files#diff-592fea17b31859cf09d8c8fe2190249b35dd84316d9d99180a0d6ff2b3fbd23fL288-R328),[[9]](https://github.com/worldcoin/walletkit/pull/349/files#diff-592fea17b31859cf09d8c8fe2190249b35dd84316d9d99180a0d6ff2b3fbd23fR394-R395))Code quality and consistency
ZERO_ADDRESSconstant for use as the null recovery agent address, improving readability and consistency. ([walletkit-core/src/issuers/recovery_bindings_manager.rsL21-R22](https://github.com/worldcoin/walletkit/pull/349/files#diff-592fea17b31859cf09d8c8fe2190249b35dd84316d9d99180a0d6ff2b3fbd23fL21-R22))bind_recovery_agentto include the new parameter. ([walletkit-core/src/issuers/recovery_bindings_manager.rsR70](https://github.com/worldcoin/walletkit/pull/349/files#diff-592fea17b31859cf09d8c8fe2190249b35dd84316d9d99180a0d6ff2b3fbd23fR70))