Skip to content

fix: enforce end-of-transcript validation in WhirR1CS verifier [LA - F]#356

Merged
ashpect merged 1 commit into
mainfrom
px/fix-eof-validation
Apr 7, 2026
Merged

fix: enforce end-of-transcript validation in WhirR1CS verifier [LA - F]#356
ashpect merged 1 commit into
mainfrom
px/fix-eof-validation

Conversation

@Bisht13

@Bisht13 Bisht13 commented Mar 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Calls VerifierState::check_eof at the end of WhirR1CSScheme::verify to reject proofs with unparsed trailing bytes in narg_string or hints
  • Addresses audit Issue F: missing end-of-transcript validation causes proof malleability

Test plan

  • cargo check -p provekit-verifier passes

@ashpect ashpect changed the title fix: enforce end-of-transcript validation in WhirR1CS verifier [F] fix: enforce end-of-transcript validation in WhirR1CS verifier [LA - F] Mar 21, 2026
@Bisht13 Bisht13 force-pushed the px/fix-eof-validation branch from 391735e to 5a6e387 Compare March 22, 2026 15:24
@Bisht13 Bisht13 force-pushed the px/fix-eof-validation branch from 5a6e387 to f1f727d Compare April 7, 2026 00:10
@ashpect ashpect merged commit c6900d5 into main Apr 7, 2026
6 of 8 checks passed
@Bisht13 Bisht13 deleted the px/fix-eof-validation branch April 7, 2026 00:54
dcbuild3r pushed a commit that referenced this pull request May 16, 2026
fix: enforce end-of-transcript validation in WhirR1CS verifier [LA - F]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants