Skip to content

fix DSC Key Smuggling via Unsigned TBS Data [LA-A] #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashpect merged 3 commits into from
Mar 26, 2026
Merged

fix DSC Key Smuggling via Unsigned TBS Data [LA-A] #368

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14d0ed0
fix DSC Key Smuggling via Unsigned TBS Data
x-senpai-x Mar 22, 2026
1cb588c
add regression tests
x-senpai-x Mar 24, 2026
2af0302
asn.1 length validation, der subjectpublickeyinfo structural validati…
x-senpai-x Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions noir-examples/noir-passport/merkle_age_check/t_add_dsc_verify_1300/src/main.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ use partial_sha256::{
SHA256State, sha256_continue, sha256_finalize, verify_sha256_state_and_data_commitment, commit_to_data_chunk,
};
use fragmented_sig_check_rsa::verify_rsa_signature;
use utils::check_zero_padding;
use utils::types::{Alpha3CountryCode, SHA256Digest};

global CHUNK1_SIZE: u32 = 640;
Expand All @@ -28,6 +29,10 @@ fn main(
"tbs_certificate_len must not exceed TBS_CERT_SIZE (1300)"
);

// Ensure all bytes beyond the signed length are zero so that trailing
// bytes cannot carry attacker-controlled data into the commitment.
check_zero_padding(tbs_certificate, tbs_certificate_len);

let mut chunk1: [u8; CHUNK1_SIZE] = [0; CHUNK1_SIZE];
for i in 0..CHUNK1_SIZE {
chunk1[i] = tbs_certificate[i];
Expand Down
Loading