Divan bench for whir#267
Open
zkfriendly wants to merge 6 commits into
Open
Conversation
Merging this PR will not alter performance
Performance Changes
Comparing Footnotes
|
zkfriendly
force-pushed
the
zkfr/divan-bench-for-whir
branch
from
July 16, 2026 09:32
f7fae70 to
3e4f3aa
Compare
zkfriendly
marked this pull request as ready for review
July 16, 2026 12:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current Divan benchmarks only cover isolated pieces of the protocol (
sumcheck,expand_from_coeff/NTT). There is no end-to-end WHIR benchmark in the Divan/CodSpeed setup. E2E WHIR timing does exist via the CLI insrc/bin/benchmark.rs, but that tool is not a Divan bench, so it is not run in CI/CodSpeed.This PR adds a
whirDivan bench target with two E2E prover benchmarks onBasefield<Field64_3>:whir_ldtβ WHIR as a low-degree test, with no linear forms or evaluation claims (commit + prove only).whir_pcsβ WHIR as a polynomial commitment scheme, with 2 multilinear evaluation openings, following the PCS path inbenchmark.rs.Both sweep vector sizes from
2^16to2^21using fixed protocol parameters (128-bit security, 20 PoW bits, folding factor 4, Blake3). Setup work (vector construction, PCS evaluation computation) stays inwith_inputs; the timed section runs the full WHIR prover flow through a sharedrun_whirhelper (domain separator, commit, prove).Test plan
cargo fmt --all --checkcargo clippy --workspace --all-targets --all-features -- -Dwarningscargo test --release --all-features --all-targets(includes compiling/running the newwhirbench)whirbench on merge (cargo codspeed build/cargo codspeed run)