Skip to content

Fix revert coreimage block width type #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theodesp wants to merge 6 commits into
base: main
Choose a base branch
from
+7 −1
Open

Fix revert coreimage block width type #340

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
530b18a
fix: remove unecessary image block width type
theodesp Feb 6, 2025
fd085dc
chore: add changeset
theodesp Feb 6, 2025
0c7a5f0
chore: phpcs lint
theodesp Feb 6, 2025
054e3a0
Update .changeset/many-garlics-divide.md
theodesp Feb 6, 2025
1c96090
chore: phpcs fix
theodesp Feb 7, 2025
18d9e8b
Update many-garlics-divide.md
theodesp Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/many-garlics-divide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@wpengine/wp-graphql-content-blocks": patch
---

Fix: reverts CoreImage block width type introduced at this [PR](https://github.com/wpengine/wp-graphql-content-blocks/pull)
3 changes: 1 addition & 2 deletions includes/Blocks/CoreImage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ class CoreImage extends Block {
'source' => 'attribute',
'attribute' => 'src',
],
'width' => [ 'type' => 'string' ],
];

/**
Expand All @@ -43,7 +42,7 @@ class CoreImage extends Block {
*/
public function __construct( WP_Block_Type $block, Registry $block_registry ) {
parent::__construct( $block, $block_registry );

register_graphql_field(
$this->type_name,
'mediaDetails',
Expand Down