Add push device update endpoints to allowed endpoints#8086
Add push device update endpoints to allowed endpoints#8086VihangaMunasinghe wants to merge 1 commit into
Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA Jinja2 XML template for resource access control is updated to extend the copyright year to 2026 and reorganize Push Device Management API resource mappings. The organization-scoped PUT endpoint is moved to group with non-organization POST and remove endpoints, and a corresponding non-organization POST endpoint is added. ChangesResource Access Control Configuration
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8086 +/- ##
============================================
- Coverage 53.15% 53.14% -0.01%
+ Complexity 20527 20517 -10
============================================
Files 2147 2147
Lines 125919 125904 -15
Branches 18044 17972 -72
============================================
- Hits 66930 66910 -20
- Misses 50781 50792 +11
+ Partials 8208 8202 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|



Purpose
The new push device update endpoint (
POST /devices/{deviceId}/update) added inidentity-api-userneeds to be registered in the resource access control configuration. Without this, the endpoint would be blocked by the framework's access control layer.Related Issue
Related PRs
Goals
Approach
<Resource>entries inresource-access-control-v2.xml.j2:(.*)/o/api/users/v1/me/push/devices/(.*)/updatewithsecured="false"for POST.(.*)/api/users/v1/me/push/devices/(.*)/updatewithsecured="false"for POST./removeendpoint entries.User stories
As a mobile app user, I want the device update endpoint to be accessible so that I can update my device's push notification token or device name.
Release note
Added the push device update endpoint (
/devices/{deviceId}/update) to the allowed endpoints in the resource access control configuration.Documentation
N/A - Internal framework configuration change. No user-facing documentation impact.
Training
N/A
Certification
N/A - Configuration change with no impact on certification content.
Marketing
N/A
Automation tests
N/A - Configuration file change only.
N/A
Security checks
Samples
N/A
Migrations (if applicable)
No migrations required. Existing deployments will pick up the new resource access control entries on upgrade.
Learning
Followed the existing pattern used by the
/removeendpoint for registering unsecured push device endpoints in both organization and tenant contexts.