Add configuration option to enable claim description in attribute name for PassiveSTS#8120
Add configuration option to enable claim description in attribute name for PassiveSTS#8120KaveeshaPiumini wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds PassiveSTS configuration support for enabling claim descriptions in attribute names. A new constant is defined in ChangesPassiveSTS Claim Description Configuration
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8120 +/- ##
============================================
- Coverage 53.13% 53.09% -0.04%
+ Complexity 20746 20727 -19
============================================
Files 2151 2151
Lines 127284 127287 +3
Branches 18745 18745
============================================
- Hits 67635 67589 -46
- Misses 51383 51436 +53
+ Partials 8266 8262 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|



Proposed changes in this pull request
This pull request introduces support for configuring whether claim descriptions should be included in attribute names for Passive STS. The main changes add a new configuration property and make it available for use in the identity server's configuration.
Configuration enhancements:
PASSIVE_STS_ENABLE_CLAIM_DESCRIPTION_IN_ATTRIBUTE_NAMEtoIdentityConstants.STSfor referencing the new configuration property.identity.xml.j2to include the new<EnableClaimDescriptionInAttributeName>element, allowing the property to be set via configuration templates.When should this PR be merged
Merge Before
Related Issue
Developer Checklist (Mandatory)
product-isissue to track any behavioral change or migration impact.Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation