Introduce new property to track runtime claims in ClaimMapping object.#8155
Introduce new property to track runtime claims in ClaimMapping object.#8155ZiyamSanthosh wants to merge 1 commit into
Conversation
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
| if ("RuntimeClaim".equals(elementName)) { | ||
| claimMapping.setRuntimeValue(Boolean.parseBoolean(element.getText())); | ||
| } |
There was a problem hiding this comment.
Log Improvement Suggestion No: 1
| if ("RuntimeClaim".equals(elementName)) { | |
| claimMapping.setRuntimeValue(Boolean.parseBoolean(element.getText())); | |
| } | |
| if ("RuntimeClaim".equals(elementName)) { | |
| claimMapping.setRuntimeValue(Boolean.parseBoolean(element.getText())); | |
| log.debug("Runtime claim value set to: " + element.getText()); | |
| } |
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughA new optional boolean field ChangesRuntimeClaim field on ClaimMapping
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
PR builder started |
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #8155 +/- ##
============================================
+ Coverage 52.77% 52.86% +0.09%
- Complexity 20809 20916 +107
============================================
Files 2173 2186 +13
Lines 128465 129432 +967
Branches 19098 19272 +174
============================================
+ Hits 67792 68429 +637
- Misses 52392 52668 +276
- Partials 8281 8335 +54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
PR builder completed |
1 similar comment
|
PR builder completed |
|
PR builder started |
|
PR builder started |
|
PR builder completed |
|
PR builder completed |
|
PR builder started |
|
PR builder completed |
|
PR builder started |
|
PR builder completed |
|
PR builder started |
|
PR builder completed |
2 participants
This pull request introduces support for a new claim property called "runtimeValue" in the claim mapping model and updates the relevant WSDL files to include this property. The main goal is to allow claims to be marked as runtime values, which can be used to indicate that their values are determined at runtime.
Model enhancements:
isRuntimeValue(with XML element nameRuntimeClaim) to theClaimMappingclass, along with corresponding getter and setter methods. [1] [2]buildmethod inClaimMappingto parse theRuntimeClaimXML element and set theisRuntimeValueproperty accordingly.Service contract updates:
runtimeValueboolean element to the claim mapping sequences in the following WSDL files to expose the property in service interfaces:IdentityDefaultSeqManagementService.wsdlIdentityApplicationManagementService.wsdlIdentityProviderMgtService.wsdl