Add flow extensions create/listing/delete support. by KD23243 · Pull Request #10349 · wso2/identity-apps

KD23243 · 2026-06-02T04:39:35Z

Purpose

Related Issues

N/A

Related PRs

N/A

Checklist

e2e cypress tests locally verified. (for internal contributers)
Manual test round performed and verified.
UX/UI review done on the final implementation.
Documentation provided. (Add links if there are any)
Relevant backend changes deployed and verified
Unit tests provided. (Add links if there are any)
Integration tests provided. (Add links if there are any)

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines
Ran FindSecurityBugs plugin and verified report
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets

Developer Checklist (Mandatory)

Complete the Developer Checklist in the related product-is issue to track any behavioral change or migration impact.

coderabbitai · 2026-06-02T04:39:43Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 21eadb63-335b-4cc3-a2c5-4faa2669a1a7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

🛠️ create changeset

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-06-02T04:46:07Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.79%. Comparing base (9aa6110) to head (3362af4).
⚠️ Report is 53 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #10349       +/-   ##
===========================================
+ Coverage   55.70%   98.79%   +43.08%     
===========================================
  Files          42      165      +123     
  Lines        1016    51775    +50759     
  Branches      254      165       -89     
===========================================
+ Hits          566    51149    +50583     
- Misses        450      626      +176

Flag	Coverage Δ
@wso2is/core	`58.95% <ø> (+3.24%)`	⬆️
@wso2is/i18n	`100.00% <100.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...n/src/translations/en-US/portals/flow-extension.ts	`100.00% <100.00%> (ø)`

... and 159 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

KD23243 · 2026-06-03T05:06:03Z

+    iconUrl?: string;
+    endpoint?: Partial<FlowExtensionEndpointInterface>;
+    accessConfig?: AccessConfigInterface;
+    flowTypeOverrides?: Record<string, AccessConfigInterface>;


Remove these

KD23243 · 2026-06-03T05:06:11Z

+    iconUrl?: string;
+    endpoint: FlowExtensionEndpointResponseInterface;
+    accessConfig?: AccessConfigInterface;
+    flowTypeOverrides?: Record<string, AccessConfigInterface>;


pavinduLakshan · 2026-06-04T02:14:38Z

-<svg xmlns="http://www.w3.org/2000/svg" viewBox="15 5 180 190" width="100%" height="100%">
-  <rect width="100%" height="100%" fill="transparent" />
-
+<svg class="icon" width="16" height="16" viewBox="15 5 180 190" fill="none" xmlns="http://www.w3.org/2000/svg">


Let's add the license header back

pavinduLakshan · 2026-06-04T02:14:55Z

@@ -0,0 +1,25 @@
+<svg class="icon" width="16" height="16" viewBox="15 5 180 190" fill="none" xmlns="http://www.w3.org/2000/svg">


Let's add the license header

pavinduLakshan · 2026-06-04T02:15:29Z

+ * Expose/modify entry in access config.
+ * Same structure is used for both expose and modify entries: a path plus an optional encryption flag.
+ */
+export interface ContextPathInterface {


it seems this interface is no longer used and can be removed. Please verify.

pavinduLakshan · 2026-06-04T02:16:35Z

+/**
+ * Access config for Flow Extension actions.
+ */
+export interface AccessConfigInterface {


interface name feels too generic. Shall we rename it to something like FlowExtensionAccessConfigInterface?

Also, should this be defined inside actions.v1?

pavinduLakshan · 2026-06-04T02:17:21Z

+import {
+    FlowExtensionCreateRequestInterface,
+    FlowExtensionResponseInterface
+} from "../models/flow-extension";


Shall we keep this in a single line for compactness?

pavinduLakshan · 2026-06-04T02:19:35Z

+>(
+        shouldFetch: boolean = true
+    ): RequestResultInterface<Data, Error> => {


shall we improve formatting here?

pavinduLakshan · 2026-06-04T02:27:03Z

@@ -0,0 +1,25 @@
+<svg class="icon" width="16" height="16" viewBox="15 5 180 190" fill="none" xmlns="http://www.w3.org/2000/svg">


Let's add the license header

pavinduLakshan · 2026-06-04T02:28:20Z

+    GENERAL_SETTINGS = "General Settings",
+    ENDPOINT_CONFIG = "Endpoint Configuration"


Is using english literals intentional here? if those are user facing text, we should i18n those.

pavinduLakshan · 2026-06-04T02:29:12Z

@@ -0,0 +1,15 @@
+{
+    "category": "DEFAULT",
+    "description": "Extend authentication flows with external services.",


using the term "authentication" is not quite accurate, is it?

pavinduLakshan · 2026-06-04T02:29:41Z

+    "id": "flow-extension",
+    "docLink": "",
+    "image": "assets/images/logos/flow-extension.svg",
+    "name": "Flow Extension",


shouldn't we use i18n for these user facing string literals?

KD23243 commented Jun 2, 2026

View reviewed changes

Comment thread features/admin.connections.v1/models/endpoints.ts Outdated

KD23243 force-pushed the flowExtensionsEffort2 branch from 83c6b59 to d3cd84d Compare June 3, 2026 03:43

KD23243 changed the title ~~Flow extensions effort2~~ Add flow extensions create/listing/delete support. Jun 3, 2026

Add flow extension connection creation, listing and delete support

3362af4

KD23243 force-pushed the flowExtensionsEffort2 branch from d3cd84d to 3362af4 Compare June 3, 2026 03:49

KD23243 commented Jun 3, 2026

View reviewed changes

pavinduLakshan reviewed Jun 4, 2026

View reviewed changes

		@@ -0,0 +1,25 @@
		<svg class="icon" width="16" height="16" viewBox="15 5 180 190" fill="none" xmlns="http://www.w3.org/2000/svg">

		GENERAL_SETTINGS = "General Settings",
		ENDPOINT_CONFIG = "Endpoint Configuration"

Conversation

KD23243 commented Jun 2, 2026

Purpose

Related Issues

Related PRs

Checklist

Security checks

Developer Checklist (Mandatory)

Uh oh!

coderabbitai Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

codecov Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Jun 2, 2026 •

edited

Loading

codecov Bot commented Jun 2, 2026 •

edited

Loading