Skip to content

Fix rules-of-hooks violation in getFilePicker #10370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KethniiImasha wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −5
Open

Fix rules-of-hooks violation in getFilePicker #10370

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e624daa
Fix rules-of-hooks violation in getFilePicker by replacing useState w…
KethniiImasha Jun 6, 2026
ff52f4f
Fix stale value passed to onCertificateChange callback
KethniiImasha Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/solid-pigs-laugh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@wso2is/admin.connections.v1": patch
---

Fix rules-of-hooks violation in getFilePicker
7 changes: 3 additions & 4 deletions features/admin.connections.v1/components/edit/forms/helpers/form-fields-helper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import {
import { I18n } from "@wso2is/i18n";
import { CopyInputField, GenericIcon, Hint, P12FileStrategy } from "@wso2is/react-components";
import { FormValidation } from "@wso2is/validation";
import React, { ReactElement, useState } from "react";
import React, { ReactElement } from "react";
import { Grid } from "semantic-ui-react";
import { Pkcs12FileField } from "./pkcs12-file-field";
import { ConnectionUIConstants } from "../../../../constants/connection-ui-constants";
Expand Down Expand Up @@ -553,13 +553,13 @@ const getDropDownField = (eachProp: CommonPluggableComponentPropertyInterface,
);
};

/* eslint-disable react-hooks/rules-of-hooks */

const getFilePicker = (eachProp: CommonPluggableComponentPropertyInterface,
propertyMetadata: CommonPluggableComponentMetaPropertyInterface,
testId?: string,
onCertificateChange?: ( newFile: string) => void): ReactElement => {

const [ data, setData ] = useState<string>(eachProp?.value);
const data: string = eachProp?.value ?? "";

return (
<>
Expand Down Expand Up @@ -592,7 +592,6 @@ const getFilePicker = (eachProp: CommonPluggableComponentPropertyInterface,
<Pkcs12FileField
onCertificateChange={ (newData: string) =>
{
setData(newData);
onCertificateChange(data);
} }
/>
Expand Down
Loading