Skip to content

Fix: Use semantic button element instead of role="button" in ActiveFiltersBar (#27945) #10406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KethniiImasha wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Use semantic button element instead of role="button" in ActiveFiltersBar (#27945) #10406

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fb87cb
fix(admin.workflow-requests): use semantic button instead of role=but…
KethniiImasha Jun 14, 2026
6192d45
chore: add console package to changeset per coding guidelines
KethniiImasha Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slimy-tools-join.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@wso2is/admin.workflow-requests.v1": patch
---

Fix accessibility issue by replacing role="button" span with semantic button element in ActiveFiltersBar
Comment thread
coderabbitai[bot] marked this conversation as resolved.
2 changes: 2 additions & 0 deletions features/admin.workflow-requests.v1/components/active-filters-bar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ $font-size-normal: 12px;
@include flex-center;
background: transparent;
border: none;
padding: 0;
font: inherit;
width: 18px;
height: 18px;
justify-content: center;
Expand Down
10 changes: 3 additions & 7 deletions features/admin.workflow-requests.v1/components/active-filters-bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,19 +56,15 @@ const ActiveFiltersBar: React.FC<ActiveFiltersBarProps> = (
<span className="filter-value">
{ filter.label }
</span>
<span
role="button"
tabIndex={ 0 }
<button
type="button"
aria-label={ t("workflowRequests:activeFiltersBar.removeFilter",
{ filter: filter.label }) }
onClick={ () => onRemove(filter) }
onKeyPress={ (e: React.KeyboardEvent) => {
if (e.key === "Enter" || e.key === " ") onRemove(filter);
} }
className="filter-remove-button"
>
<Icon name="close" size="small" className="icon" />
</span>
</button>
</div>
))
) : (
Expand Down
Loading