Skip protocol template fetch and edit redirect for flow extension connections#10445
Skip protocol template fetch and edit redirect for flow extension connections#10445KD23243 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo files are updated to skip network fetches for the Flow Extension connection template. The create wizard factory introduces a ChangesFlow Extension Template Fetch Guards
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10445 +/- ##
=======================================
Coverage 72.71% 72.71%
=======================================
Files 469 469
Lines 70846 70858 +12
Branches 484 484
=======================================
+ Hits 51513 51525 +12
Misses 19037 19037
Partials 296 296 🚀 New features to boost your workflow:
|
Purpose
Flow extension connections are created through their own dedicated wizard in
ConnectionCreateWizardFactoryand have no protocol template. The generic authenticator create wizard was still issuing the protocol template fetch and the duplicate-name lookup for these connections, and the connection edit page was not treating them like the other template-driven connections. This change skips the unnecessary fetches and aligns the edit-page handling for flow extension connections.Implementation
TEMPLATES_WITH_DEDICATED_WIZARDlist inauthenticator-create-wizard-factory.tsxcontaining the flow extension template id, and a derivedhasDedicatedWizardflag.shouldFetchTemplatecheck.connection-edit.tsxso it is handled consistently with the other template-driven connections.