Skip to content

Skip protocol template fetch and edit redirect for flow extension connections#10445

Open
KD23243 wants to merge 1 commit into
wso2:masterfrom
KD23243:fixFlowExtensionWizard
Open

Skip protocol template fetch and edit redirect for flow extension connections#10445
KD23243 wants to merge 1 commit into
wso2:masterfrom
KD23243:fixFlowExtensionWizard

Conversation

@KD23243

@KD23243 KD23243 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Purpose

Flow extension connections are created through their own dedicated wizard in ConnectionCreateWizardFactory and have no protocol template. The generic authenticator create wizard was still issuing the protocol template fetch and the duplicate-name lookup for these connections, and the connection edit page was not treating them like the other template-driven connections. This change skips the unnecessary fetches and aligns the edit-page handling for flow extension connections.

Implementation

  • Introduced a TEMPLATES_WITH_DEDICATED_WIZARD list in authenticator-create-wizard-factory.tsx containing the flow extension template id, and a derived hasDedicatedWizard flag.
  • Used the flag to skip both the duplicate-name connections lookup and the protocol template fetch for connections with a dedicated wizard, replacing the previous inline shouldFetchTemplate check.
  • Added the flow extension template id to the early-return condition in connection-edit.tsx so it is handled consistently with the other template-driven connections.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: ba386d7d-1db3-4d23-8cfd-3816bd1a81b9

📥 Commits

Reviewing files that changed from the base of the PR and between be9663e and d8c26b6.

📒 Files selected for processing (2)
  • features/admin.connections.v1/components/create/authenticator-create-wizard-factory.tsx
  • features/admin.connections.v1/pages/connection-edit.tsx

📝 Walkthrough

Walkthrough

Two files are updated to skip network fetches for the Flow Extension connection template. The create wizard factory introduces a TEMPLATES_WITH_DEDICATED_WIZARD constant and a derived hasDedicatedWizard flag to gate useGetConnectionTemplate. The connection-edit page adds FLOW_EXTENSION to an existing early-return guard that prevents getConnectionMetaDetails from being called.

Changes

Flow Extension Template Fetch Guards

Layer / File(s) Summary
Dedicated-wizard constant and template fetch guard
features/admin.connections.v1/components/create/authenticator-create-wizard-factory.tsx
Adds module-level TEMPLATES_WITH_DEDICATED_WIZARD constant (containing the Flow Extension template ID), derives hasDedicatedWizard from type, and updates the useGetConnectionTemplate call to skip fetching when hasDedicatedWizard is true, replacing the previous inline single-template check.
Connection-edit meta-detail fetch early return
features/admin.connections.v1/pages/connection-edit.tsx
Extends the useEffect early-return condition to include FLOW_EXTENSION alongside OUTBOUND_PROVISIONING_CONNECTION, preventing getConnectionMetaDetails from being invoked for that template.

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Changeset Required ❌ Error PR changes features/admin.connections.v1 but changeset (fix-documentation-links.md) doesn't list @wso2is/admin.connections.v1; only @wso2is/admin.core.v1 and @wso2is/console are documented. Add @wso2is/admin.connections.v1 to the changeset file with appropriate version bump, or create a new changeset documenting the flow extension connection changes.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: skipping protocol template fetch and edit redirect for flow extension connections, which is the core focus of both file modifications.
Description check ✅ Passed The description comprehensively covers the purpose, implementation details, and technical context. However, it omits most checklist items and doesn't reference related issues or PRs as specified in the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ create changeset

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.71%. Comparing base (455aa6c) to head (d8c26b6).
⚠️ Report is 23 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10445   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files         469      469           
  Lines       70846    70858   +12     
  Branches      484      484           
=======================================
+ Hits        51513    51525   +12     
  Misses      19037    19037           
  Partials      296      296           

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant