Add j2 changes to support disable retry message building in backend OAuth flow#13908
Open
msm1992 wants to merge 1 commit intowso2:masterfrom
Open
Add j2 changes to support disable retry message building in backend OAuth flow#13908msm1992 wants to merge 1 commit intowso2:masterfrom
msm1992 wants to merge 1 commit intowso2:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds Jinja2 template configuration support for a new synapse property that controls retry message building behavior in backend OAuth flows. The changes enable conditional rendering of the synapse.endpoint.http.oauth.token.retry.message.building.disabled property based on the presence of a new configuration variable.
- Adds conditional template block for
disable_retry_message_buildingconfiguration - Updates synapse.properties.j2 templates across all deployment modules
- Supports the corresponding synapse PR #2409
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| traffic-manager/modules/distribution/product/src/main/resources/conf/templates/repository/conf/synapse.properties.j2 | Adds conditional rendering of retry message building disabled property for traffic manager module |
| gateway/modules/distribution/product/src/main/resources/conf/templates/repository/conf/synapse.properties.j2 | Adds conditional rendering of retry message building disabled property for gateway module |
| api-control-plane/modules/distribution/product/src/main/resources/conf/templates/repository/conf/synapse.properties.j2 | Adds conditional rendering of retry message building disabled property for API control plane module |
| all-in-one-apim/modules/distribution/product/src/main/resources/conf/templates/repository/conf/synapse.properties.j2 | Adds conditional rendering of retry message building disabled property for all-in-one APIM module |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
c04859c to
e63a7e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds config changes for wso2/wso2-synapse#2409
Todo