Skip to content

fix: close redis connections on unsubscribe #2917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dkorittki wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −1
Draft

fix: close redis connections on unsubscribe #2917

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c314e9
fix: close redis connections on unsubscribe
dkorittki Jun 4, 2026
b273296
fix: use correct format identifier in Sprintf
dkorittki Jun 4, 2026
13eb7e7
fix: use fixed timeout for unsubscribe
dkorittki Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion router/pkg/pubsub/redis/adapter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"errors"
"fmt"
"sync"
"time"

"github.com/wundergraph/cosmo/router/pkg/metric"

Expand Down Expand Up @@ -100,10 +101,18 @@ func (p *ProviderAdapter) Subscribe(ctx context.Context, conf datasource.Subscri
msgChan := sub.Channel()

cleanup := func() {
err := sub.PUnsubscribe(ctx, subConf.Channels...)
unsubCtx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
defer cancel()

err := sub.PUnsubscribe(unsubCtx, subConf.Channels...)
if err != nil {
log.Error(fmt.Sprintf("error unsubscribing from redis for topics %v", subConf.Channels), zap.Error(err))
}

err = sub.Close()
if err != nil {
log.Error(fmt.Sprintf("error closing connection to redis: %v", zap.Error(err)))
}
Comment thread
dkorittki marked this conversation as resolved.
}

p.closeWg.Add(1)
Expand Down
Loading