Skip to content

fix: fix typename selection edge case#2936

Open
devsergiy wants to merge 1 commit into
mainfrom
fix/fix-typename-selection-edge-case
Open

fix: fix typename selection edge case#2936
devsergiy wants to merge 1 commit into
mainfrom
fix/fix-typename-selection-edge-case

Conversation

@devsergiy

@devsergiy devsergiy commented Jun 9, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated GraphQL tools library dependency to the latest version.

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/docs-website.
  • I have read the Contributors Guide.

Open Source AI Manifesto

This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.

@devsergiy devsergiy requested a review from a team as a code owner June 9, 2026 09:37
@github-actions github-actions Bot added the router label Jun 9, 2026
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d9f2fe6b-e9c6-4873-90f7-b19080a25ff6

📥 Commits

Reviewing files that changed from the base of the PR and between 9224bc0 and 708b8ef.

⛔ Files ignored due to path filters (2)
  • router-tests/go.sum is excluded by !**/*.sum
  • router/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • router-tests/go.mod
  • router/go.mod

Walkthrough

Both router/go.mod and router-tests/go.mod are updated to upgrade github.com/wundergraph/graphql-go-tools/v2 from v2.4.4 to v2.4.5-0.20260609090547-581c62aa180c, applying the same dependency version change across both module manifests.

Changes

Dependency Version Update

Layer / File(s) Summary
graphql-go-tools version bump
router/go.mod, router-tests/go.mod
Both router/go.mod (line 34) and router-tests/go.mod (line 34) update the github.com/wundergraph/graphql-go-tools/v2 dependency from v2.4.4 to v2.4.5-0.20260609090547-581c62aa180c, keeping the router and test dependencies synchronized.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly Related PRs

  • wundergraph/cosmo#2913: Also updates github.com/wundergraph/graphql-go-tools/v2 in both router/go.mod and router-tests/go.mod.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions a typename selection edge case fix, but the actual changes are only dependency version updates in go.mod files with no code changes addressing this issue. Update the title to accurately reflect the actual changes, such as 'chore: upgrade graphql-go-tools dependency' or provide the actual typename selection fix implementation.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

❌ Internal Query Planner CI checks failed

The Internal Query Planner CI checks failed in the celestial repository, and this is going to stop the merge of this PR.
If you are part of the WunderGraph organization, you can see the PR with more details.

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.75%. Comparing base (9224bc0) to head (708b8ef).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2936      +/-   ##
==========================================
+ Coverage   65.13%   65.75%   +0.62%     
==========================================
  Files         327      258      -69     
  Lines       47127    27309   -19818     
  Branches     5239        0    -5239     
==========================================
- Hits        30697    17958   -12739     
+ Misses      16406     7903    -8503     
- Partials       24     1448    +1424     

see 585 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant