Skip to content

feat(router): entity cache OTEL/Prometheus metrics (4/6)#2952

Merged
SkArchon merged 0 commit into
milinda/entity-caching-2-routerfrom
milinda/entity-caching-2b-metrics
Jun 10, 2026
Merged

feat(router): entity cache OTEL/Prometheus metrics (4/6)#2952
SkArchon merged 0 commit into
milinda/entity-caching-2-routerfrom
milinda/entity-caching-2b-metrics

Conversation

@SkArchon

Copy link
Copy Markdown
Contributor

Part 4 of 6 — split out from #2777. Stacked on #2945.

What's included

The tree at this PR's tip is byte-identical to the pre-split router branch — the split is purely for reviewability.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fcdfde53-dfa5-421c-a174-a4721c27db2a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

Router-nonroot image scan failed

❌ Security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-97fa19415db8041a6a69758bb1f2fd98161e7a70-nonroot

Please check the security vulnerabilities found in the PR.

If you believe this is a false positive, please add the vulnerability to the .trivyignore file and re-run the scan.

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 9.59596% with 179 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.73%. Comparing base (1ee462b) to head (36deda8).

Files with missing lines Patch % Lines
router/pkg/metric/entity_cache_metrics.go 0.00% 153 Missing ⚠️
router/core/graph_server.go 12.00% 19 Missing and 3 partials ⚠️
router/core/graphql_handler.go 55.55% 4 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           milinda/entity-caching-2-router    #2952      +/-   ##
===================================================================
- Coverage                            57.64%   56.73%   -0.92%     
===================================================================
  Files                                  245      246       +1     
  Lines                                27734    27922     +188     
===================================================================
- Hits                                 15988    15842     -146     
- Misses                               10165    10486     +321     
- Partials                              1581     1594      +13     
Files with missing lines Coverage Δ
router/core/router.go 66.68% <100.00%> (+0.04%) ⬆️
router/pkg/config/config.go 42.96% <ø> (ø)
router/pkg/metric/config.go 67.50% <ø> (ø)
router/pkg/otel/attributes.go 62.50% <ø> (ø)
router/core/graphql_handler.go 61.08% <55.55%> (-2.34%) ⬇️
router/core/graph_server.go 78.43% <12.00%> (-1.26%) ⬇️
router/pkg/metric/entity_cache_metrics.go 0.00% <0.00%> (ø)

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SkArchon SkArchon force-pushed the milinda/entity-caching-2-router branch from 3cc3d77 to b8d95ae Compare June 10, 2026 15:08
@SkArchon SkArchon force-pushed the milinda/entity-caching-2b-metrics branch from cea064b to 2f35a32 Compare June 10, 2026 15:08
@SkArchon SkArchon force-pushed the milinda/entity-caching-2-router branch from 1cf7860 to e5ea054 Compare June 10, 2026 16:31
@SkArchon SkArchon force-pushed the milinda/entity-caching-2b-metrics branch 2 times, most recently from b60df65 to 6680842 Compare June 10, 2026 18:27
@SkArchon SkArchon force-pushed the milinda/entity-caching-2-router branch from e5ea054 to 4bce8f5 Compare June 10, 2026 18:27
@SkArchon SkArchon force-pushed the milinda/entity-caching-2b-metrics branch from 6680842 to aa274e0 Compare June 10, 2026 18:53
@SkArchon SkArchon force-pushed the milinda/entity-caching-2-router branch from 4bce8f5 to 43b3919 Compare June 10, 2026 18:53
@SkArchon SkArchon force-pushed the milinda/entity-caching-2b-metrics branch from aa274e0 to 36deda8 Compare June 10, 2026 18:59
@SkArchon SkArchon force-pushed the milinda/entity-caching-2-router branch from 43b3919 to 1ee462b Compare June 10, 2026 18:59
@SkArchon SkArchon merged commit c88671f into milinda/entity-caching-2-router Jun 10, 2026
@SkArchon SkArchon force-pushed the milinda/entity-caching-2-router branch from 1ee462b to c88671f Compare June 10, 2026 19:16
@SkArchon SkArchon deleted the milinda/entity-caching-2b-metrics branch June 10, 2026 19:16
@SkArchon SkArchon force-pushed the milinda/entity-caching-2b-metrics branch from 36deda8 to c88671f Compare June 10, 2026 19:16
@SkArchon

Copy link
Copy Markdown
Contributor Author

Auto-closed as merged by a force-push mishap. Replaced by #2956.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant