Stop rotation from reloading the WebView (closes #14)#56
Open
jim-daf wants to merge 1 commit intowwWallet:mainfrom
Open
Stop rotation from reloading the WebView (closes #14)#56jim-daf wants to merge 1 commit intowwWallet:mainfrom
jim-daf wants to merge 1 commit intowwWallet:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Android MainActivity manifest configuration to prevent activity recreation on device rotation (and related configuration changes), ensuring the embedded WebView keeps its document/JS/session state as reported in #14.
Changes:
- Expand
android:configChangesonMainActivityto include orientation and screen/UX-related configuration flags.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop rotation from reloading the WebView
Closes #14
What changed
wrapper/src/main/AndroidManifest.xmlAdd the orientation, screen size, and related configuration changes to the existing
android:configChangesattribute onMainActivity. With these in place, Android no longer destroys and recreates the activity when the device rotates, so the hosted WebView keeps its document, its JavaScript state, and any signed-in user.Key snippet
Why these flags
orientationandscreenSizeare the pair Android requires to suppress activity recreation on rotation since API 13.screenLayoutandsmallestScreenSizecover foldables and split-screen transitions.uiModecovers system theme switches (day, night, car), which would otherwise also reset the WebView.