Skip to content

Added Language Module#1

Open
Entree3k wants to merge 105 commits intox1ao4:mainfrom
Entree3k:main
Open

Added Language Module#1
Entree3k wants to merge 105 commits intox1ao4:mainfrom
Entree3k:main

Conversation

@Entree3k
Copy link
Copy Markdown

Added a Language Module so you can see what Language a movie is in. Also has ability to skip dual audio videos so you can just see files that have one audio track

Entree3k added 2 commits June 19, 2024 13:10
Language.py is for detecting the Language of an audio track
return None

# Mapping of common language codes to full names in alphabetical order
language_mapping = {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to extend this to also support language tags?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like mi, en, da, etc? or what tag format?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also referred to as locales. Here's another reference.

Personally example much of my library includes Arabic that's either dubbed into both classical/modern standard arabic (ar) or egyptian arabic (ar-eg).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing that will need to be updated along with this is the main README

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also referred to as locales. Here's another reference.

Personally example much of my library includes Arabic that's either dubbed into both classical/modern standard arabic (ar) or egyptian arabic (ar-eg).

image
My languages are based on language codes you would find in mkvtoolnix to define audio tracks

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. So would I be using this designation going forward for any ar-eg files?

@amadib
Copy link
Copy Markdown

amadib commented Jul 5, 2024

@x1ao4 this would be a welcomed addition

@x1ao4
Copy link
Copy Markdown
Owner

x1ao4 commented Jul 5, 2024

@x1ao4 this would be a welcomed addition

I've been a bit busy lately, but I'll review and consider this PR when I have some free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants