CP-312094: Update rate limiting design document#7000
Open
cplaursen wants to merge 3 commits intoxapi-project:masterfrom
Open
CP-312094: Update rate limiting design document#7000cplaursen wants to merge 3 commits intoxapi-project:masterfrom
cplaursen wants to merge 3 commits intoxapi-project:masterfrom
Conversation
Signed-off-by: Christian Pardillo Laursen <christian.pardillolaursen@citrix.com>
lindig
approved these changes
Apr 9, 2026
Address @lindig's comments Signed-off-by: Christian Pardillo Laursen <christian.pardillolaursen@citrix.com>
Address Rob's comments Signed-off-by: Christian Pardillo Laursen <christian.pardillolaursen@citrix.com>
psafont
reviewed
Apr 23, 2026
Comment on lines
+202
to
+204
| - **Rate limiting**: Only the most specific match (which has rate limiting | ||
| enabled) for any given request will trigger rate limiting and deduct tokens | ||
| from its token bucket. |
Member
There was a problem hiding this comment.
Won't this produce counterintuitive behaviour? for example "foo*: with a rate limit of 10 and "foo" with a rate limit of 5 means that "foo* can sustain up to a rate of 15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update addresses some comments I've received on the design document. Most importantly, I add a new table for rate limiters which allows us to combine several callers under 1 rate limiter in a straightforward way.