xapi/attach_helpers: remove useless check for leaked vbds #7035
Draft
xapi/attach_helpers: remove useless check for leaked vbds #7035
Conversation
Gate the checks done for the other_config keys task_id and related_to to VBDs associated with control domains Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
Looks like this mechanism was used in the past, and only one vestigial check on VBD creation was used. It does not make sense to create a VBD associated with a task and immediately check whether it has leaked. Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
lindig
approved these changes
Apr 27, 2026
robhoes
reviewed
Apr 27, 2026
| let has_task = List.mem_assoc Xapi_globs.vbd_task_key other_config in | ||
| let has_related = List.mem_assoc Xapi_globs.related_to_key other_config in | ||
| if (not has_task) && not has_related then ( | ||
| if (not can_leak) || ((not has_task) && not has_related) then ( |
Member
There was a problem hiding this comment.
If not can_leak means "not a control domain", doesn't this conflict with the comment below?
Member
There was a problem hiding this comment.
Oh it's all gone in the second commit...
Member
Author
There was a problem hiding this comment.
I can find this code is used on vdi clone and copy, so there was nothing to ensure this code applied to only control domains. I believe the comment to be wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like this mechanism was used in the past, and only one vestigial
check on VBD creation was used.
It does not make sense to create a VBD associated with a task and
immediately check whether it has leaked.