Skip to content

Fix invalid default geometry #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pont-us merged 3 commits into from
Sep 15, 2026
+9 −5
Merged

Fix invalid default geometry #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0545d1
Add regression test: Generated STAC not valid
Hneuschmidt Sep 15, 2026
ff29b01
Fix: STAC geometry not valid
Hneuschmidt Sep 15, 2026
77c97c0
Update changelog
pont-us Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* Allow creation of EOAP-only and xcube-server-only images, omitting
unnecessary dependencies (#56)
* Add support for notebook-assisted stage-in (#23, #91, #95)
* Make stage-out catalogue geometry field GeoJSON-compliant (#101)

## Changes in 0.1.2

Expand Down
1 change: 1 addition & 0 deletions test/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ def test_write_stac(tmp_path, dataset, write_datasets, pre_existing_catalog):
],
"ds2": [str((tmp_path / "ds2" / "ds2.nc").resolve(strict=False))],
}
catalog.validate_all()


def test_write_stac_no_pystac(tmp_path, dataset):
Expand Down
12 changes: 7 additions & 5 deletions xcengine/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,13 @@ class Bounds(NamedTuple):
geometry={
"type": "Polygon",
"coordinates": [
[bb.left, bb.bottom],
[bb.left, bb.top],
[bb.right, bb.top],
[bb.right, bb.bottom],
[bb.left, bb.bottom],
[
[bb.left, bb.bottom],
[bb.left, bb.top],
[bb.right, bb.top],
[bb.right, bb.bottom],
[bb.left, bb.bottom],
]
],
},
bbox=[bb.left, bb.bottom, bb.right, bb.top],
Expand Down
Loading