-
Notifications
You must be signed in to change notification settings - Fork 6
Let the user build its own randomizer engine to fix the seed and get reproductible results. #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ class Extension | |
| { | ||
| protected Randomizer $randomizer; | ||
|
|
||
| public function __construct(Randomizer $randomizer) | ||
| final public function __construct(Randomizer $randomizer) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this creates a BC break, given that
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I discussed this point with
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I understand why you did this, but it can breaks some extensions if someone modified the constructor. I need to talk about this with @GautierDele too |
||
| { | ||
| $this->randomizer = $randomizer; | ||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.