Skip to content

Add the container as an extension constructor parameter to build "composable extensions". #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sukei wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

Add the container as an extension constructor parameter to build "composable extensions". #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Container/Traits/HasExtensions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public function resolveExtensions(array $extensions): self
*/
protected function resolve(\Xefi\Faker\Extensions\Extension|string $extension): Container
{
$instance = $extension instanceof Extension ? $extension : new $extension(new Randomizer());
$instance = $extension instanceof Extension ? $extension : new $extension(new Randomizer(), $this);

// If the extension supports locale variations
if (method_exists($instance, 'getLocale')) {
Expand Down
6 changes: 5 additions & 1 deletion src/Extensions/Extension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,18 @@

use Random\Randomizer;
use ReflectionClass;
use Xefi\Faker\Container\Container;

class Extension
{
protected Randomizer $randomizer;

public function __construct(Randomizer $randomizer)
protected Container $container;

final public function __construct(Randomizer $randomizer, Container $container)
{
$this->randomizer = $randomizer;
$this->container = $container;
}

/**
Expand Down