Skip to content

:rotating_lights: Fix unit tests does are NOK anymore#90

Merged
martinsoenen merged 2 commits into
mainfrom
issue-89
Jul 20, 2026
Merged

:rotating_lights: Fix unit tests does are NOK anymore#90
martinsoenen merged 2 commits into
mainfrom
issue-89

Conversation

@martinsoenen

@martinsoenen martinsoenen commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Tests
    • Adjusted randomized element test assertions to normalize the expected array consistently when comparing results.
  • Chores
    • Improved automated test workflow reliability by expanding the test matrix for dependency tiers.
    • Updated CI steps to validate composer.json without requiring the lockfile and to install dependencies using a dedicated installer action.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 65f41f5b-34e6-4224-9c65-31b5ed16712f

📥 Commits

Reviewing files that changed from the base of the PR and between cb50f92 and 3bbe659.

📒 Files selected for processing (1)
  • .github/workflows/tests.yml

📝 Walkthrough

Walkthrough

Changes

Test validation

Layer / File(s) Summary
Normalize random element assertion
tests/Unit/Extensions/ArraysExtensionTest.php
The test compares returned elements with the fixture’s values, excluding array keys, using canonicalizing equality.
Expand CI dependency coverage
.github/workflows/tests.yml
The workflow tests lowest and highest Composer dependency sets, validates composer.json without the lock file, and uses ramsey/composer-install@v3 for installation.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately reflects the main intent: fixing failing unit tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-89

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@martinsoenen
martinsoenen merged commit b4c4603 into main Jul 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant