WIP: Implement IO safely#7
Open
noughtmare wants to merge 1 commit into
Open
Conversation
Author
|
The CountDown (This is with I have run the benchmarks with the Hackage version of eveff and it shows that this new version is about 5-12% slower than that. With the most slowdown, around 10%, in the big stack benchmark and the rest are mostly around the 5%. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




See #6.
The main change is adding an
IOlayer toCtl:The rest of the changes are basically the minimum necessary changes to make this work.
This influences the benchmarks somewhat, but it seems like those changes are mostly limited to a few missed optimization opportunities which are probably not present in larger programs anyway. Nevertheless, I still think it is something that can be investigated further. I think a change to GHC like https://gitlab.haskell.org/ghc/ghc/-/issues/19617 would help.
Here are the benchmark results on my computer:
So about 10%-50% worse performance with an outlier of 600% in TestState due to a missed optimization opportunities.